-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hw1 quantize check #30
Comments
Yep! Feel free to open a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I feel like the check might be inadequate?
https://github.com/mitmath/18S191/blob/123040947d5b03a572b58c261b3009c8041b5c4e/homework/homework1/hw1.jl#L986-L1000
Since it is checking 0.3,
floor
with anydigits
≥ 1 will pass, when really we wantdigits=1
.The text was updated successfully, but these errors were encountered: