Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in reading resource files should be more descriptive and user-friendly #13

Open
sseago opened this issue Jul 1, 2021 · 9 comments
Assignees
Labels
documentation Improvements or additions to documentation kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sseago
Copy link
Contributor

sseago commented Jul 1, 2021

If there are files under exportDir that don't contain valid resource yaml, the user will see a low-level error message that doesn't indicate what the CLI was trying to do or why it failed. For example, one possible error the user might see is:

Error: Object 'Kind' is missing in 'null'

This sort of message does nothing to tell the user that there's a problem in the files found in the export directory.

@shawn-hurley shawn-hurley added kind/bug Categorizes issue or PR as related to a bug. documentation Improvements or additions to documentation labels Jul 6, 2021
@djzager djzager added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 18, 2022
@eriknelson
Copy link
Contributor

/triage accepted
/priority normal

@openshift-ci openshift-ci bot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. labels Jun 24, 2022
@eriknelson eriknelson assigned djzager and unassigned eemcmullan Jun 24, 2022
@github-actions
Copy link

This issue synced with: https://issues.redhat.com/browse/MIG-1248

@migtools migtools deleted a comment from openshift-ci bot Jun 24, 2022
@eriknelson
Copy link
Contributor

/remove needs-triage

@eriknelson
Copy link
Contributor

/label ?

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2022

@eriknelson: The label(s) /label ? cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, cherry-pick-approved

In response to this:

/label ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eriknelson
Copy link
Contributor

/remove-triage

@eriknelson
Copy link
Contributor

/remove-label needs-triage

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2022

@eriknelson: The label(s) /remove-label needs-triage cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, cherry-pick-approved

In response to this:

/remove-label needs-triage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eriknelson eriknelson removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 24, 2022
@eriknelson
Copy link
Contributor

^ done manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants