Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments are counted towards coverage #24188

Closed
deepak1556 opened this issue Sep 25, 2024 · 1 comment
Closed

Comments are counted towards coverage #24188

deepak1556 opened this issue Sep 25, 2024 · 1 comment
Assignees
@eleanorjboyd
Labels
info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team

Comments

@deepak1556
Copy link

Testing #24160

Screen.Recording.2024-09-25.at.9.33.12.mov
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 25, 2024
@eleanorjboyd
Copy link
Member

I think this makes sense as the coverage is # of lines covered / total so removing a line should change this fraction (since the print line is hit when not commented out) which could cause the percentage change.

@eleanorjboyd eleanorjboyd closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2024
@github-actions github-actions bot added the info-needed Issue requires more information from poster label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleanorjboyd eleanorjboyd

Labels
info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deepak1556 @eleanorjboyd