Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Create Environment" does not create .gitignore #24151

Closed
bersbersbers opened this issue Sep 23, 2024 · 0 comments · Fixed by #24155
Closed

Bug: "Create Environment" does not create .gitignore #24151

bersbersbers opened this issue Sep 23, 2024 · 0 comments · Fixed by #24155
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team

Comments

@bersbersbers
Copy link

bersbersbers commented Sep 23, 2024

Behaviour

"Create Environment" does not create .gitignore file

Steps to reproduce:

  1. "Create Environment"
  2. Check .gitignore file

Diagnostic data

The problem was introduced in 462b9bf - someone dropped a not in one of the two add_gitignore implementations (the conda one is fine, the venv one is not):

image

Still in v2024.14.1:

def add_gitignore(name: str) -> None:
git_ignore = CWD / name / ".gitignore"
if git_ignore.is_file():
print("Creating:", os.fspath(git_ignore))
git_ignore.write_text("*")

@bersbersbers bersbersbers added the feature-request Request for new features or functionality label Sep 23, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 23, 2024
@karthiknadig karthiknadig self-assigned this Sep 23, 2024
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants