Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check auto refresh setting during pytest discovery #24117

Open
rchiodo opened this issue Sep 16, 2024 · 7 comments
Open

Check auto refresh setting during pytest discovery #24117

rchiodo opened this issue Sep 16, 2024 · 7 comments
Assignees
Labels
area-testing feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@rchiodo
Copy link

rchiodo commented Sep 16, 2024

I'm working on some code that uses Cython for optimizations. Every time I regen the Cython output, I get an error that it can't create the pyd files. This is because every time I change the python code, the test discovery runs.

It would be nice if there was a way to make test discovery have a manual refresh instead of auto refresh.

@rchiodo rchiodo added the feature-request Request for new features or functionality label Sep 16, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 16, 2024
@karthiknadig
Copy link
Member

Unsetting this should stop it.
image

@rchiodo
Copy link
Author

rchiodo commented Sep 16, 2024

Closing? Seems like my request was already possible, I just didn't know about the setting.

@rchiodo rchiodo closed this as completed Sep 16, 2024
@rchiodo
Copy link
Author

rchiodo commented Sep 16, 2024

I looked for a command to enable/disable it. I should have looked in the settings too.

@rchiodo
Copy link
Author

rchiodo commented Sep 17, 2024

Reopening. It doesn't seem to work. I still get a refresh. Do I need to reload VS code for this to work?

@rchiodo rchiodo reopened this Sep 17, 2024
@karthiknadig
Copy link
Member

@rchiodo Yes. The events are added on load I think.

@eleanorjboyd This could be something that we can make more configurable. i.e, we can ignore the events when setting is disabled?

@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Sep 18, 2024
@github-actions github-actions bot added the info-needed Issue requires more information from poster label Sep 18, 2024
@eleanorjboyd
Copy link
Member

eleanorjboyd commented Sep 23, 2024

@karthiknadig are you saying that the setting should be more responsive and not require and reload on vscode to work?

@karthiknadig
Copy link
Member

In the handler for files modified, we can check if this setting is disabled.

@eleanorjboyd eleanorjboyd changed the title Allow disabling of auto refresh for pytest discovery Check auto refresh setting during pytest discovery Oct 1, 2024
@eleanorjboyd eleanorjboyd added feature-request Request for new features or functionality area-testing needs PR Ready to be worked on and removed bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants