From c25667861a963a17b3ba934c995a15944048bfeb Mon Sep 17 00:00:00 2001
From: Kartik Raj <karraj@microsoft.com>
Date: Tue, 18 Jul 2023 17:26:39 -0700
Subject: [PATCH] Prevent posix paths locator from crashing (#21657)

For https://github.com/microsoft/vscode-python/issues/21310
---
 .../lowLevel/posixKnownPathsLocator.ts        | 32 +++++++++++--------
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/src/client/pythonEnvironments/base/locators/lowLevel/posixKnownPathsLocator.ts b/src/client/pythonEnvironments/base/locators/lowLevel/posixKnownPathsLocator.ts
index 2e4e2dc13e61..4cacbd53f5aa 100644
--- a/src/client/pythonEnvironments/base/locators/lowLevel/posixKnownPathsLocator.ts
+++ b/src/client/pythonEnvironments/base/locators/lowLevel/posixKnownPathsLocator.ts
@@ -27,23 +27,27 @@ export class PosixKnownPathsLocator extends Locator<BasicEnvInfo> {
 
         const iterator = async function* (kind: PythonEnvKind) {
             traceVerbose('Searching for interpreters in posix paths locator');
-            // Filter out pyenv shims. They are not actual python binaries, they are used to launch
-            // the binaries specified in .python-version file in the cwd. We should not be reporting
-            // those binaries as environments.
-            const knownDirs = (await commonPosixBinPaths()).filter((dirname) => !isPyenvShimDir(dirname));
-            let pythonBinaries = await getPythonBinFromPosixPaths(knownDirs);
+            try {
+                // Filter out pyenv shims. They are not actual python binaries, they are used to launch
+                // the binaries specified in .python-version file in the cwd. We should not be reporting
+                // those binaries as environments.
+                const knownDirs = (await commonPosixBinPaths()).filter((dirname) => !isPyenvShimDir(dirname));
+                let pythonBinaries = await getPythonBinFromPosixPaths(knownDirs);
 
-            // Filter out MacOS system installs of Python 2 if necessary.
-            if (isMacPython2Deprecated) {
-                pythonBinaries = pythonBinaries.filter((binary) => !isMacDefaultPythonPath(binary));
-            }
+                // Filter out MacOS system installs of Python 2 if necessary.
+                if (isMacPython2Deprecated) {
+                    pythonBinaries = pythonBinaries.filter((binary) => !isMacDefaultPythonPath(binary));
+                }
 
-            for (const bin of pythonBinaries) {
-                try {
-                    yield { executablePath: bin, kind, source: [PythonEnvSource.PathEnvVar] };
-                } catch (ex) {
-                    traceError(`Failed to process environment: ${bin}`, ex);
+                for (const bin of pythonBinaries) {
+                    try {
+                        yield { executablePath: bin, kind, source: [PythonEnvSource.PathEnvVar] };
+                    } catch (ex) {
+                        traceError(`Failed to process environment: ${bin}`, ex);
+                    }
                 }
+            } catch (ex) {
+                traceError('Failed to process posix paths', ex);
             }
             traceVerbose('Finished searching for interpreters in posix paths locator');
         };