From d1de833d1be49672dec3f84cc9ed42ad0fbc8e58 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Fri, 4 Feb 2022 17:15:27 +0100 Subject: [PATCH 1/7] Try to reproduce https://github.com/microsoft/vscode-pull-request-github/issues/3294 --- src/commands.ts | 1 + src/commentHandlerResolver.ts | 1 + src/constants.ts | 1 + src/experimentationService.ts | 1 + src/extension.ts | 1 + src/extensionState.ts | 1 + src/gitExtensionIntegration.ts | 1 + src/gitProviders/builtinGit.ts | 1 + src/gitProviders/vslshost.ts | 1 + 9 files changed, 9 insertions(+) diff --git a/src/commands.ts b/src/commands.ts index 9356ce0406..23ac4910eb 100644 --- a/src/commands.ts +++ b/src/commands.ts @@ -4,6 +4,7 @@ *--------------------------------------------------------------------------------------------*/ 'use strict'; + import * as pathLib from 'path'; import * as vscode from 'vscode'; import { GitErrorCodes } from './api/api1'; diff --git a/src/commentHandlerResolver.ts b/src/commentHandlerResolver.ts index 8fa56f0caa..1f5583e8ee 100644 --- a/src/commentHandlerResolver.ts +++ b/src/commentHandlerResolver.ts @@ -4,6 +4,7 @@ *--------------------------------------------------------------------------------------------*/ 'use strict'; + import * as vscode from 'vscode'; import Logger from './common/logger'; import { GHPRComment, GHPRCommentThread, TemporaryComment } from './github/prComment'; diff --git a/src/constants.ts b/src/constants.ts index 9a22a865f9..e0c16540ea 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -3,6 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ + export const EXTENSION_ID = 'GitHub.vscode-pull-request-github'; export const VSLS_REQUEST_NAME = 'git'; export const VSLS_GIT_PR_SESSION_NAME = 'ghpr'; diff --git a/src/experimentationService.ts b/src/experimentationService.ts index 0bb018fd17..e3188a6beb 100644 --- a/src/experimentationService.ts +++ b/src/experimentationService.ts @@ -3,6 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ + import * as vscode from 'vscode'; import TelemetryReporter from 'vscode-extension-telemetry'; import { diff --git a/src/extension.ts b/src/extension.ts index 7335c5c171..dbf368e232 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -3,6 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ + 'use strict'; import * as vscode from 'vscode'; import TelemetryReporter from 'vscode-extension-telemetry'; diff --git a/src/extensionState.ts b/src/extensionState.ts index 85c01cd61b..b624c86f69 100644 --- a/src/extensionState.ts +++ b/src/extensionState.ts @@ -5,6 +5,7 @@ import * as vscode from 'vscode'; import { IAccount } from './github/interface'; + // Synced keys export const NEVER_SHOW_PULL_NOTIFICATION = 'github.pullRequest.pullNotification.show'; diff --git a/src/gitExtensionIntegration.ts b/src/gitExtensionIntegration.ts index 2eadf399ce..50cda1759e 100644 --- a/src/gitExtensionIntegration.ts +++ b/src/gitExtensionIntegration.ts @@ -7,6 +7,7 @@ import { RemoteSource, RemoteSourceProvider } from './@types/git'; import { OctokitCommon } from './github/common'; import { AuthProvider, CredentialStore, GitHub } from './github/credentials'; + interface Repository { readonly full_name: string; readonly description: string | null; diff --git a/src/gitProviders/builtinGit.ts b/src/gitProviders/builtinGit.ts index 54dcecae40..343a3803eb 100644 --- a/src/gitProviders/builtinGit.ts +++ b/src/gitProviders/builtinGit.ts @@ -12,6 +12,7 @@ export class BuiltinGitProvider implements IGit, vscode.Disposable { return this._gitAPI.repositories as any[]; } + get state(): APIState { return this._gitAPI.state; } diff --git a/src/gitProviders/vslshost.ts b/src/gitProviders/vslshost.ts index 1dc86ea9f3..f2b1bb32bb 100644 --- a/src/gitProviders/vslshost.ts +++ b/src/gitProviders/vslshost.ts @@ -13,6 +13,7 @@ import { VSLS_STATE_CHANGE_NOTIFY_NAME, } from '../constants'; + export class VSLSHost implements vscode.Disposable { private _sharedService?: SharedService; private _disposables: vscode.Disposable[]; From bea27856c220faf87b96d8902d8cf44f72cc980b Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Fri, 4 Feb 2022 17:20:09 +0100 Subject: [PATCH 2/7] Make a commit to try to repro --- src/commands.ts | 1 + src/commentHandlerResolver.ts | 1 + src/constants.ts | 1 + src/experimentationService.ts | 1 + src/extensionState.ts | 1 + src/gitProviders/builtinGit.ts | 2 ++ src/gitProviders/vslshost.ts | 1 + 7 files changed, 8 insertions(+) diff --git a/src/commands.ts b/src/commands.ts index 23ac4910eb..a5494fd1ab 100644 --- a/src/commands.ts +++ b/src/commands.ts @@ -30,6 +30,7 @@ import { ReviewManager } from './view/reviewManager'; import { CategoryTreeNode } from './view/treeNodes/categoryNode'; import { CommitNode } from './view/treeNodes/commitNode'; import { DescriptionNode } from './view/treeNodes/descriptionNode'; + import { GitFileChangeNode, InMemFileChangeNode, diff --git a/src/commentHandlerResolver.ts b/src/commentHandlerResolver.ts index 1f5583e8ee..24ce12e827 100644 --- a/src/commentHandlerResolver.ts +++ b/src/commentHandlerResolver.ts @@ -24,6 +24,7 @@ export interface CommentHandler { unresolveReviewThread(thread: GHPRCommentThread, input?: string): Promise; } + export interface CommentReply { thread: GHPRCommentThread & { value: GHPRCommentThread }; text: string; diff --git a/src/constants.ts b/src/constants.ts index e0c16540ea..ec781fc1da 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -7,6 +7,7 @@ export const EXTENSION_ID = 'GitHub.vscode-pull-request-github'; export const VSLS_REQUEST_NAME = 'git'; export const VSLS_GIT_PR_SESSION_NAME = 'ghpr'; + export const VSLS_REPOSITORY_INITIALIZATION_NAME = 'initialize'; export const VSLS_STATE_CHANGE_NOTIFY_NAME = 'statechange'; export const FOCUS_REVIEW_MODE = 'github:focusedReview'; diff --git a/src/experimentationService.ts b/src/experimentationService.ts index e3188a6beb..55c9769022 100644 --- a/src/experimentationService.ts +++ b/src/experimentationService.ts @@ -14,6 +14,7 @@ import { } from 'vscode-tas-client'; /* __GDPR__ + "query-expfeature" : { "ABExp.queriedFeature": { "classification": "SystemMetaData", "purpose": "FeatureInsight" } } diff --git a/src/extensionState.ts b/src/extensionState.ts index b624c86f69..2c5d521c43 100644 --- a/src/extensionState.ts +++ b/src/extensionState.ts @@ -15,6 +15,7 @@ export const REPO_KEYS = 'github.pullRequest.repos'; export interface RepoState { mentionableUsers?: IAccount[]; stateModifiedTime?: number; + } export interface ReposState { diff --git a/src/gitProviders/builtinGit.ts b/src/gitProviders/builtinGit.ts index 343a3803eb..c4626b5206 100644 --- a/src/gitProviders/builtinGit.ts +++ b/src/gitProviders/builtinGit.ts @@ -15,6 +15,8 @@ export class BuiltinGitProvider implements IGit, vscode.Disposable { get state(): APIState { return this._gitAPI.state; + + } private _onDidOpenRepository = new vscode.EventEmitter(); diff --git a/src/gitProviders/vslshost.ts b/src/gitProviders/vslshost.ts index f2b1bb32bb..d7c7f4fd30 100644 --- a/src/gitProviders/vslshost.ts +++ b/src/gitProviders/vslshost.ts @@ -21,6 +21,7 @@ export class VSLSHost implements vscode.Disposable { this._disposables = []; } + public async initialize() { this._sharedService = (await this._liveShareAPI!.shareService(VSLS_GIT_PR_SESSION_NAME)) || undefined; From 4c0c95c115f2dd9e44e6386d2c9c4b4628247ee0 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Fri, 4 Feb 2022 17:21:13 +0100 Subject: [PATCH 3/7] See if it repros again --- src/constants.ts | 1 + src/experimentationService.ts | 2 ++ src/extension.ts | 1 + src/extensionState.ts | 3 ++- src/gitExtensionIntegration.ts | 2 ++ 5 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/constants.ts b/src/constants.ts index ec781fc1da..9454c366c7 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -9,5 +9,6 @@ export const VSLS_REQUEST_NAME = 'git'; export const VSLS_GIT_PR_SESSION_NAME = 'ghpr'; export const VSLS_REPOSITORY_INITIALIZATION_NAME = 'initialize'; + export const VSLS_STATE_CHANGE_NOTIFY_NAME = 'statechange'; export const FOCUS_REVIEW_MODE = 'github:focusedReview'; diff --git a/src/experimentationService.ts b/src/experimentationService.ts index 55c9769022..87e9441c29 100644 --- a/src/experimentationService.ts +++ b/src/experimentationService.ts @@ -11,6 +11,7 @@ import { IExperimentationService, IExperimentationTelemetry, TargetPopulation, + } from 'vscode-tas-client'; /* __GDPR__ @@ -20,6 +21,7 @@ import { } */ + export class ExperimentationTelemetry implements IExperimentationTelemetry { private sharedProperties: Record = {}; diff --git a/src/extension.ts b/src/extension.ts index dbf368e232..192629a28b 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -13,6 +13,7 @@ import { GitApiImpl } from './api/api1'; import { registerCommands } from './commands'; import Logger from './common/logger'; import * as PersistentState from './common/persistentState'; + import { Resource } from './common/resources'; import { SessionState } from './common/sessionState'; import { FILE_LIST_LAYOUT } from './common/settingKeys'; diff --git a/src/extensionState.ts b/src/extensionState.ts index 2c5d521c43..c0e05a3dd3 100644 --- a/src/extensionState.ts +++ b/src/extensionState.ts @@ -14,8 +14,9 @@ export const REPO_KEYS = 'github.pullRequest.repos'; export interface RepoState { mentionableUsers?: IAccount[]; + stateModifiedTime?: number; - + } export interface ReposState { diff --git a/src/gitExtensionIntegration.ts b/src/gitExtensionIntegration.ts index 50cda1759e..6f305ca478 100644 --- a/src/gitExtensionIntegration.ts +++ b/src/gitExtensionIntegration.ts @@ -13,6 +13,7 @@ interface Repository { readonly description: string | null; readonly clone_url: string; readonly ssh_url: string; + } function repoResponseAsRemoteSource(raw: OctokitCommon.SearchReposResponseItem): RemoteSource { @@ -21,6 +22,7 @@ function repoResponseAsRemoteSource(raw: OctokitCommon.SearchReposResponseItem): description: raw.description || undefined, url: raw.url, }; + } function asRemoteSource(raw: Repository): RemoteSource { From 67e7726cd8294b2ff4e4b3c92ab21e1d883f78cf Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Fri, 4 Feb 2022 17:37:50 +0100 Subject: [PATCH 4/7] Another test commit --- src/commands.ts | 2 ++ src/commentHandlerResolver.ts | 2 ++ src/constants.ts | 2 ++ src/experimentationService.ts | 2 ++ src/extensionState.ts | 3 ++- src/gitProviders/builtinGit.ts | 2 ++ src/gitProviders/vslshost.ts | 4 +++- 7 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/commands.ts b/src/commands.ts index a5494fd1ab..f70450f998 100644 --- a/src/commands.ts +++ b/src/commands.ts @@ -5,6 +5,8 @@ 'use strict'; + + import * as pathLib from 'path'; import * as vscode from 'vscode'; import { GitErrorCodes } from './api/api1'; diff --git a/src/commentHandlerResolver.ts b/src/commentHandlerResolver.ts index 24ce12e827..aef2b0d40f 100644 --- a/src/commentHandlerResolver.ts +++ b/src/commentHandlerResolver.ts @@ -5,6 +5,8 @@ 'use strict'; + + import * as vscode from 'vscode'; import Logger from './common/logger'; import { GHPRComment, GHPRCommentThread, TemporaryComment } from './github/prComment'; diff --git a/src/constants.ts b/src/constants.ts index 9454c366c7..c8e4fd1570 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -4,6 +4,8 @@ *--------------------------------------------------------------------------------------------*/ + + export const EXTENSION_ID = 'GitHub.vscode-pull-request-github'; export const VSLS_REQUEST_NAME = 'git'; export const VSLS_GIT_PR_SESSION_NAME = 'ghpr'; diff --git a/src/experimentationService.ts b/src/experimentationService.ts index 87e9441c29..25e903cf97 100644 --- a/src/experimentationService.ts +++ b/src/experimentationService.ts @@ -4,6 +4,8 @@ *--------------------------------------------------------------------------------------------*/ + + import * as vscode from 'vscode'; import TelemetryReporter from 'vscode-extension-telemetry'; import { diff --git a/src/extensionState.ts b/src/extensionState.ts index c0e05a3dd3..1944c64725 100644 --- a/src/extensionState.ts +++ b/src/extensionState.ts @@ -3,7 +3,8 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as vscode from 'vscode'; -import { IAccount } from './github/interface'; +import +{ IAccount } from './github/interface'; // Synced keys diff --git a/src/gitProviders/builtinGit.ts b/src/gitProviders/builtinGit.ts index c4626b5206..1d8470f918 100644 --- a/src/gitProviders/builtinGit.ts +++ b/src/gitProviders/builtinGit.ts @@ -19,6 +19,8 @@ export class BuiltinGitProvider implements IGit, vscode.Disposable { } + + private _onDidOpenRepository = new vscode.EventEmitter(); readonly onDidOpenRepository: vscode.Event = this._onDidOpenRepository.event; private _onDidCloseRepository = new vscode.EventEmitter(); diff --git a/src/gitProviders/vslshost.ts b/src/gitProviders/vslshost.ts index d7c7f4fd30..5daafcf727 100644 --- a/src/gitProviders/vslshost.ts +++ b/src/gitProviders/vslshost.ts @@ -14,6 +14,8 @@ import { } from '../constants'; + + export class VSLSHost implements vscode.Disposable { private _sharedService?: SharedService; private _disposables: vscode.Disposable[]; @@ -21,7 +23,7 @@ export class VSLSHost implements vscode.Disposable { this._disposables = []; } - + public async initialize() { this._sharedService = (await this._liveShareAPI!.shareService(VSLS_GIT_PR_SESSION_NAME)) || undefined; From 0e23d56e2e188917469a1fc28b83a0cb4f6a538d Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Mon, 7 Feb 2022 13:28:58 +0100 Subject: [PATCH 5/7] Make more changes to repro the bug --- src/commands.ts | 2 ++ src/commentHandlerResolver.ts | 2 ++ src/constants.ts | 2 ++ src/experimentationService.ts | 2 ++ src/extension.ts | 2 ++ src/extensionState.ts | 4 +++- src/gitExtensionIntegration.ts | 4 +++- src/gitProviders/builtinGit.ts | 4 +++- src/gitProviders/vslshost.ts | 2 ++ 9 files changed, 21 insertions(+), 3 deletions(-) diff --git a/src/commands.ts b/src/commands.ts index f70450f998..277a36398c 100644 --- a/src/commands.ts +++ b/src/commands.ts @@ -9,6 +9,8 @@ import * as pathLib from 'path'; import * as vscode from 'vscode'; + + import { GitErrorCodes } from './api/api1'; import { CommentReply, resolveCommentHandler } from './commentHandlerResolver'; import { IComment } from './common/comment'; diff --git a/src/commentHandlerResolver.ts b/src/commentHandlerResolver.ts index aef2b0d40f..6e4b63d439 100644 --- a/src/commentHandlerResolver.ts +++ b/src/commentHandlerResolver.ts @@ -8,6 +8,8 @@ import * as vscode from 'vscode'; + + import Logger from './common/logger'; import { GHPRComment, GHPRCommentThread, TemporaryComment } from './github/prComment'; diff --git a/src/constants.ts b/src/constants.ts index c8e4fd1570..3e29f67cc8 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -8,6 +8,8 @@ export const EXTENSION_ID = 'GitHub.vscode-pull-request-github'; export const VSLS_REQUEST_NAME = 'git'; + + export const VSLS_GIT_PR_SESSION_NAME = 'ghpr'; export const VSLS_REPOSITORY_INITIALIZATION_NAME = 'initialize'; diff --git a/src/experimentationService.ts b/src/experimentationService.ts index 25e903cf97..af9c0a0594 100644 --- a/src/experimentationService.ts +++ b/src/experimentationService.ts @@ -16,6 +16,8 @@ import { } from 'vscode-tas-client'; + + /* __GDPR__ "query-expfeature" : { diff --git a/src/extension.ts b/src/extension.ts index 192629a28b..f8495081ee 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -10,6 +10,8 @@ import TelemetryReporter from 'vscode-extension-telemetry'; import { LiveShare } from 'vsls/vscode.js'; import { Repository } from './api/api'; import { GitApiImpl } from './api/api1'; + + import { registerCommands } from './commands'; import Logger from './common/logger'; import * as PersistentState from './common/persistentState'; diff --git a/src/extensionState.ts b/src/extensionState.ts index 1944c64725..a15d72bb28 100644 --- a/src/extensionState.ts +++ b/src/extensionState.ts @@ -26,4 +26,6 @@ export interface ReposState { export function setSyncedKeys(context: vscode.ExtensionContext) { context.globalState.setKeysForSync([NEVER_SHOW_PULL_NOTIFICATION]); -} \ No newline at end of file +} + + diff --git a/src/gitExtensionIntegration.ts b/src/gitExtensionIntegration.ts index 6f305ca478..df39928531 100644 --- a/src/gitExtensionIntegration.ts +++ b/src/gitExtensionIntegration.ts @@ -8,6 +8,8 @@ import { OctokitCommon } from './github/common'; import { AuthProvider, CredentialStore, GitHub } from './github/credentials'; + + interface Repository { readonly full_name: string; readonly description: string | null; @@ -22,7 +24,7 @@ function repoResponseAsRemoteSource(raw: OctokitCommon.SearchReposResponseItem): description: raw.description || undefined, url: raw.url, }; - + } function asRemoteSource(raw: Repository): RemoteSource { diff --git a/src/gitProviders/builtinGit.ts b/src/gitProviders/builtinGit.ts index 1d8470f918..143db0d145 100644 --- a/src/gitProviders/builtinGit.ts +++ b/src/gitProviders/builtinGit.ts @@ -13,6 +13,8 @@ export class BuiltinGitProvider implements IGit, vscode.Disposable { } + + get state(): APIState { return this._gitAPI.state; @@ -20,7 +22,7 @@ export class BuiltinGitProvider implements IGit, vscode.Disposable { } - + private _onDidOpenRepository = new vscode.EventEmitter(); readonly onDidOpenRepository: vscode.Event = this._onDidOpenRepository.event; private _onDidCloseRepository = new vscode.EventEmitter(); diff --git a/src/gitProviders/vslshost.ts b/src/gitProviders/vslshost.ts index 5daafcf727..f657d3c4dd 100644 --- a/src/gitProviders/vslshost.ts +++ b/src/gitProviders/vslshost.ts @@ -11,6 +11,8 @@ import { VSLS_REPOSITORY_INITIALIZATION_NAME, VSLS_REQUEST_NAME, VSLS_STATE_CHANGE_NOTIFY_NAME, + + } from '../constants'; From d2771f69e9bc4627ada28444b5cccd3e4ef4c27b Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Mon, 7 Feb 2022 13:37:17 +0100 Subject: [PATCH 6/7] Yet another test commit --- src/commands.ts | 1 - src/commentHandlerResolver.ts | 1 - src/constants.ts | 1 - src/experimentationService.ts | 1 - src/extension.ts | 1 - src/extensionState.ts | 1 - src/gitExtensionIntegration.ts | 3 --- 7 files changed, 9 deletions(-) diff --git a/src/commands.ts b/src/commands.ts index 277a36398c..51dea9e295 100644 --- a/src/commands.ts +++ b/src/commands.ts @@ -6,7 +6,6 @@ - import * as pathLib from 'path'; import * as vscode from 'vscode'; diff --git a/src/commentHandlerResolver.ts b/src/commentHandlerResolver.ts index 6e4b63d439..360717913d 100644 --- a/src/commentHandlerResolver.ts +++ b/src/commentHandlerResolver.ts @@ -6,7 +6,6 @@ - import * as vscode from 'vscode'; diff --git a/src/constants.ts b/src/constants.ts index 3e29f67cc8..e975c4df96 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -5,7 +5,6 @@ - export const EXTENSION_ID = 'GitHub.vscode-pull-request-github'; export const VSLS_REQUEST_NAME = 'git'; diff --git a/src/experimentationService.ts b/src/experimentationService.ts index af9c0a0594..707ca46a37 100644 --- a/src/experimentationService.ts +++ b/src/experimentationService.ts @@ -5,7 +5,6 @@ - import * as vscode from 'vscode'; import TelemetryReporter from 'vscode-extension-telemetry'; import { diff --git a/src/extension.ts b/src/extension.ts index f8495081ee..61773cc976 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -11,7 +11,6 @@ import { LiveShare } from 'vsls/vscode.js'; import { Repository } from './api/api'; import { GitApiImpl } from './api/api1'; - import { registerCommands } from './commands'; import Logger from './common/logger'; import * as PersistentState from './common/persistentState'; diff --git a/src/extensionState.ts b/src/extensionState.ts index a15d72bb28..915fefb475 100644 --- a/src/extensionState.ts +++ b/src/extensionState.ts @@ -28,4 +28,3 @@ export function setSyncedKeys(context: vscode.ExtensionContext) { context.globalState.setKeysForSync([NEVER_SHOW_PULL_NOTIFICATION]); } - diff --git a/src/gitExtensionIntegration.ts b/src/gitExtensionIntegration.ts index df39928531..46d66b181e 100644 --- a/src/gitExtensionIntegration.ts +++ b/src/gitExtensionIntegration.ts @@ -7,9 +7,6 @@ import { RemoteSource, RemoteSourceProvider } from './@types/git'; import { OctokitCommon } from './github/common'; import { AuthProvider, CredentialStore, GitHub } from './github/credentials'; - - - interface Repository { readonly full_name: string; readonly description: string | null; From a2cc75f577e15b7acb94316b25f6c72e5450a554 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Mon, 7 Feb 2022 13:55:05 +0100 Subject: [PATCH 7/7] getting closer... --- src/commands.ts | 1 + src/commentHandlerResolver.ts | 1 + src/constants.ts | 1 + src/extension.ts | 1 + src/extensionState.ts | 1 + 5 files changed, 5 insertions(+) diff --git a/src/commands.ts b/src/commands.ts index 51dea9e295..277a36398c 100644 --- a/src/commands.ts +++ b/src/commands.ts @@ -6,6 +6,7 @@ + import * as pathLib from 'path'; import * as vscode from 'vscode'; diff --git a/src/commentHandlerResolver.ts b/src/commentHandlerResolver.ts index 360717913d..6e4b63d439 100644 --- a/src/commentHandlerResolver.ts +++ b/src/commentHandlerResolver.ts @@ -6,6 +6,7 @@ + import * as vscode from 'vscode'; diff --git a/src/constants.ts b/src/constants.ts index e975c4df96..3e29f67cc8 100644 --- a/src/constants.ts +++ b/src/constants.ts @@ -5,6 +5,7 @@ + export const EXTENSION_ID = 'GitHub.vscode-pull-request-github'; export const VSLS_REQUEST_NAME = 'git'; diff --git a/src/extension.ts b/src/extension.ts index 61773cc976..a6898905b7 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -4,6 +4,7 @@ *--------------------------------------------------------------------------------------------*/ + 'use strict'; import * as vscode from 'vscode'; import TelemetryReporter from 'vscode-extension-telemetry'; diff --git a/src/extensionState.ts b/src/extensionState.ts index 915fefb475..61d1975ca3 100644 --- a/src/extensionState.ts +++ b/src/extensionState.ts @@ -7,6 +7,7 @@ import { IAccount } from './github/interface'; + // Synced keys export const NEVER_SHOW_PULL_NOTIFICATION = 'github.pullRequest.pullNotification.show';