Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Status Badges Are Referencing Bad Foreground Color #5622

Open
pouyakary opened this issue Jan 16, 2024 · 0 comments · May be fixed by #5624
Open

PR Status Badges Are Referencing Bad Foreground Color #5622

pouyakary opened this issue Jan 16, 2024 · 0 comments · May be fixed by #5624
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@pouyakary
Copy link
Contributor

  • Extension version: 0.78.1
  • VSCode Version: 1.85.1
  • OS: Irrelevant
  • Repository Clone Configuration (single repository/fork of an upstream repository): Irrelevant
  • Github Product (Github.com/Github Enterprise version x.x.x): Irrelevant

The extension references the wrong foreground color for the PR Status badges:

I'm noticing this because my theme has colors that are not supposed to be used for the foreground of these badges:

Screenshot 1402-10-26 at 3 21 04 PM

Since the badge colors are customizable, the foreground colors must be as well. I'm going to make a PR that addresses this issue.
@pouyakary pouyakary changed the title PR Status References Wrong Foreground Color PR Status & Issue Badges Are Referencing Bad Foreground Color Jan 16, 2024
@pouyakary pouyakary changed the title PR Status & Issue Badges Are Referencing Bad Foreground Color PR Status Badges Are Referencing Bad Foreground Color Jan 16, 2024
@pouyakary pouyakary linked a pull request Jan 16, 2024 that will close this issue
Open
@alexr00 alexr00 self-assigned this Jan 19, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5622 pouyakary/vscode-pull-request-github
2 participants
@pouyakary @alexr00