Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify / unify api a little #13

Open
kesla opened this issue Apr 25, 2016 · 0 comments
Open

Simplify / unify api a little #13

kesla opened this issue Apr 25, 2016 · 0 comments

Comments

@kesla
Copy link
Contributor

kesla commented Apr 25, 2016

I think that we should remove the url field when possible, for example when we parse instgram we return both the url and the id - but we can create the url from the id.

Similarly we return both the twitter url - but also the twitter id and the twitter username.

Oh, we should probably also rename youtubeId in youtube to id.

@iefserge @ellell WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant