[Feature Request]: Change out lewisxhe/PCF8563_Library

[ellisgl]

Platform

ESP32

Description

I see that there has been more active development on one of it's forks: https://github.com/CDFER/pcf8563-RTC

[ellisgl]

Assign it to me - I'll get it done. =)

[ellisgl]

#5031

[caveman99]

Could you explain what is the difference? E.G. what actual problem does this solve? We generally stick with the upstream libs and advocate merging such changes upstream 'it is more active in development' can mean everything and nothing.

[ellisgl]

@caveman99

• lewisxhe/PCF8563_Library was last updated 2022-10-06.
• CDFER/pcf8563-RTC was created in 2023-03-21, and was last updated 2024-08-17.
• CDFER/pcf8563-RTC name of the lib actually tells you what's it's for.
• CDFER/pcf8563-RTC is way better documented. lewisxhe/PCF8563_Library has a name and a simple example.
• CDFER/pcf8563-RTC has several bug fixes:
  • Fix sync to RTC
  • Timezone Bugfix
  • Make sync functions fail safe
• CDFER/pcf8563-RTC has several improvements:
  • Use UTC time not local timezone
  • Faster epoch creation
  • Add error to text function

[caveman99]

From the library readme:

• Not all functions are implemented
• Not compatible with Lewis' library
• Only tested with the ESP32 and S2 variants

We use this with all kinds of processor arches, and the way you built up the code request you assume it's a drop in replacement, which it is not. Alone the change from local zone to UTC requires code changes in meshtastic. I am not in favor of doing this.

[ellisgl]

@caveman99 I thought I saw it said something about having backwards compatibility. I'm feeling like a stooge now. I think I'll dig more into this and see what I can do about solving those issues.

[fifieldt]

Appreciate your work @ellisgl !