For PSD.js, publish dist folder instead of CoffeeScript for portability
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancejpollard
commented
Feb 1, 2024
| @@ -38,6 +38,7 @@ module.exports = class PSD extends Module | |||
| # the PSD object. However, if you already have the PSD data stored as a Uint8Array, | |||
| # you can instantiate the PSD object directly. | |||
| constructor: (data) -> | |||
| super() | |||
There was a problem hiding this comment.
Had to do this to resolve errors such as:
ERROR in ./lib/psd/blend_mode.coffee
Module build failed (from ./node_modules/coffee-loader/dist/cjs.js):
CoffeeScriptError: ./psd.js/lib/psd/blend_mode.coffee:43:5: error: Can't reference 'this' before calling super in derived class constructors
@blendKey = null
^
at Object.loader (./psd.js/node_modules/coffee-loader/dist/index.js:33:14)
@ ./lib/psd/layer/blend_modes.coffee 3:12-43
@ ./lib/psd/layer.coffee 71:17-54
@ ./lib/psd/layer_mask.coffee 7:8-33
@ ./lib/psd.coffee 34:12-46
|
I'm getting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #287 I think, or something like this.