Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Add public key fingerprint to the encryption envelope in secrets.yml. #5

Open
aaronsteers opened this issue Dec 2, 2022 · 0 comments

Comments

@aaronsteers
Copy link

aaronsteers commented Dec 2, 2022

As we adapt for scenarios where the KMS key is not known at runtime because we are using standard RSA encryption and not native AWS functions, I think it's important to be able to distinguish when 'decryption failure' is due to 'wrong key' versus some other issue such as encoding, escaping, truncation, etc.

I would propose we attach a public key fingerprint using MD5 or SHA, whichever allows easier matching to KMS.

This will significantly aid troubleshooting, since then without sending any confidential information, an administrator can see if there's a key match issue.

Priority-wise, this doesn't have to be top priority. If it's easy and we can knock it out, then great. But also, it's probably okay if we add later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant