Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter parameters for GET /partij-identificatoren are incorrect in the openapi.yaml #257

Open
anna-ritense opened this issue Oct 3, 2024 · 0 comments
Labels
bug Something isn't working triage

Comments

@anna-ritense
Copy link

Product versie / Product version

2.1.0+

Omschrijf het probleem / Describe the bug

The filter parameters described for the GET /pratij-identificatoren query are incorrect.

Actual filter parameters as seen in the code here are different.

There might be a serialization issue where snake_case is turned into camelCase when generating the openapi.yaml

Stappen om te reproduceren / Steps to reproduce

  1. Replace placeholders in following curl:
curl -X GET --location "http://localhost:{{PORT}}/klantinteracties/api/v1/partij-identificatoren?partijIdentificatorCodeSoortObjectId={{BSN}}" \
    -H "Content-Type: application/json" \
    -H "Authorization: Token {{TOKEN}}"
  1. Run this curl command.
  2. Observe that documented filter doesn't work.

Verwacht gedrag / Expected behavior

It is really difficult and costly to implement an API spec that is wrong. This holds back adoption and causes frustration for those that do wish to use OpenKlant 2.X.X.

@anna-ritense anna-ritense added bug Something isn't working triage labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

1 participant