-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added evm_setBlockGasLimit #332
base: main
Are you sure you want to change the base?
Conversation
i do not see test for endpoint in the file diff |
i can not find |
sorry, forgot to commit - should be there now |
ditto |
Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com>
Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com>
Co-authored-by: AnastasiiaVashchuk <72273339+AnastasiiaVashchuk@users.noreply.github.com>
I see the implementation, but we have the following situation. |
Well, one could still lower the limit in the test environment, even if the real blockchain doesn't support it, for testing... But OK, if you think it would be too confusing, just close the issue... |
In what way? |
OK, but the test node environment should use the variable, affecting (e.g.) gas estimation - IOW although the value inside the VM doesn't change, it is possible to make a transaction fail just by lowering the limit... I can imagine testing how much higher is the maximum than some specific transactions (those in the test suite, for example)... |
What π»
Implemented the evm_setBlockGasLimit API.
Why β
Fixes #324 .
Evidence π·
Added test, which passes:
hardhat testsuite also can use the API: