Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: configure globally cython cdivision/checkbound + change them on travis #137

Open
mathurinm opened this issue Jun 11, 2020 · 0 comments
Open

ENH: configure globally cython cdivision/checkbound + change them on travis #137

mathurinm opened this issue Jun 11, 2020 · 0 comments

Comments

@mathurinm
Copy link
Owner

  1. avoid repetition of the block:
@cython.boundscheck(False)
@cython.wraparound(False)
@cython.cdivision(True)
  1. Not having these options when running on CI may catch more bugs (as [FIX] random test failure when ws_size reaches n_features #136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathurinm