Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook Event Connection Timeout #376

Open
jrosco opened this issue Mar 16, 2023 · 0 comments
Open

Webhook Event Connection Timeout #376

jrosco opened this issue Mar 16, 2023 · 0 comments

Comments

@jrosco
Copy link

jrosco commented Mar 16, 2023

Environment:

Confidant version: 6.3.0
python-confidant-client py version: 2.1.0 (used with our webhook listener app secret-updater )

Issue:

When sending an event to a webhook endpoint (in this case secret-updater) we see this connection timeout in the Confidant logs

[confidant] WARNING:confidant.services.webhook:Failed to post webhook event. HTTPConnectionPool(host='secret-updater', port=80): Read timed out. (read timeout=3)

Looking at the file https://github.com/lyft/confidant/blob/6.3.0/confidant/services/webhook.py#L30 I can see it's using a timeout of 3 seconds in the POST response which corresponds the timeout shown in logs

 response = requests.post(
            webhook_url,
            auth=(username, password),
            headers=headers,
            data=json.dumps(event),
            timeout=3
        )

Could this be the issue regrading the timeouts when posting events to webhooks? and if so would it be possible to update and set this timeout value via configuration / variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant