Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes #1

Open
kisvegabor opened this issue Sep 22, 2022 · 2 comments
Open

Some fixes #1

kisvegabor opened this issue Sep 22, 2022 · 2 comments

Comments

@kisvegabor
Copy link
Member

kisvegabor commented Sep 22, 2022 •
edited
Loading

Hi,

I've added some fixes and optimizations. See in the history.

Sorry for not sending a PR but we'd like to make a tutorial video about this board and planning to use this repo. So I needed to have the changes merged. 🙈

Please let me know you have any remarks. 🙂
@epichl25
Copy link
Collaborator

Hi @kisvegabor ,

I've briefly skimmed through the changes you've made and it looks good. However, I believe DMA2D won't work if the pixel format is set to RGB565 by default in stm32h7b3i_discovery_lcd.c as I remember setting the colour mode to ARGB8888.

@kisvegabor
Copy link
Member Author

Here I've modified the color format to RGB565.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kisvegabor @epichl25