-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain is not parsed correctly for run.app
#308
Comments
RezaRahmati
changed the title
domain is not parsed correctly
domain is not parsed correctly for run.app
Feb 26, 2023
RezaRahmati
changed the title
domain is not parsed correctly for run.app
domain is not parsed correctly for Feb 26, 2023
run.app
I do not think this is an issue. As per publicsuffix/list#1710 run.app is already on the list. Moreover, |
I think I'm having a similar issue:
Gives me:
|
I am having the same issue with altervista.org which is also on the list. Why? Lil fix on my end to deal with this😹 import psl from 'psl';
const url = "https://altervista.org"
let domain = new URL(url).host
let domainParse = psl.parse(domain);
let rootDomain = domainParse.domain || domainParse.tld
console.log('domain: ' + domain)
console.log(domainParse)
console.log('rootDomain: ' + rootDomain) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
expected:
run.app
actual:
health-check-tool-2-api-izeboapi4q-nn.a.run.app
version:
"psl": "^1.9.0",
p.s
app.run
is the default google cloud run domainfrom examples on readme
Also added a request publicsuffix/list#1710
The text was updated successfully, but these errors were encountered: