Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split data layer to separate class #83

Closed
Konard opened this issue May 28, 2021 · 2 comments · Fixed by #94
Closed

Split data layer to separate class #83

Konard opened this issue May 28, 2021 · 2 comments · Fixed by #94
Labels
good first issue Good for newcomers help wanted Extra attention is needed reward This issue have an reward that is paid on completion.

Comments

@Konard
Copy link
Member

Konard commented May 28, 2021 •
edited
Loading

1000 RUB reward can be claimed by anyone who completes this task.

It can be named DataService or DataLayer or DataApi or something better.
All usages of BetterBotBase should be removed from the main (V) class.
These usages should be moved to a separate class (with separate file).
@Konard Konard added good first issue Good for newcomers reward This issue have an reward that is paid on completion. help wanted Extra attention is needed labels Jun 11, 2021
@dry71
Copy link
Member

dry71 commented Jul 16, 2021

https://github.com/linksplatform/Bot/blob/DataService/python/DataService.py

@Konard Konard pinned this issue Oct 28, 2021
@Konard Konard linked a pull request Dec 2, 2021 that will close this issue
Data service #94
Merged
@Konard Konard closed this as completed in #94 Dec 2, 2021
@Konard
Copy link
Member Author

Konard commented Dec 2, 2021

Rewards are:
700 RUB for @dry71
300 RUB for @Ethosa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed reward This issue have an reward that is paid on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Data service linksplatform/Bot
2 participants
@Konard @dry71