Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect_music_type() does not detect valid MPEG Audio files #558

Open
Fulgen301 opened this issue Sep 19, 2023 · 2 comments
Open

detect_music_type() does not detect valid MPEG Audio files #558

Fulgen301 opened this issue Sep 19, 2023 · 2 comments
Labels

Comments

@Fulgen301
Copy link

#288 reported missing support for an MPEG Audio frame header starting with the first eleven bits. However, an MPEG file could start anywhere (e.g. in the middle of a frame) and audio players should seek to the first occurence of those frame sync bits and check whether the header is valid.

I encountered this issue when I was informed that certain MPEG-1 files weren't loaded by Mix_LoadWAV_RW with Unrecognized audio format. The same audio files are played by mpg123 and vlc without issues, so while the source for this behavior isn't an official document, it seems to be the case that MPEG Audio files are in fact allowed to start anywhere.

@slouken
Copy link
Collaborator

slouken commented Jan 14, 2024

Can you provide a link to an example file that doesn't load correctly?

@Fulgen301
Copy link
Author

Fulgen301 commented Jul 18, 2024

Better late than never, sorry about that: https://fulgen.at/files/011.wav (it has the wrong file extension as it contains MPEG data, but SDL_mixer doesn't check them anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants