Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildbot core not showing GIT_VERSION in library version and performance difference compared to self-built core #6

Open
Ryunam opened this issue Jun 1, 2021 · 0 comments

Comments

@Ryunam
Copy link

Ryunam commented Jun 1, 2021

With PR #5 I have implemented the visualization of the commit hash for the library version string in libretro.cpp, in addition to the emulator version itself which is currently hard-coded to 115.

When bsnes-libretro is compiled locally on my Windows system with MSYS2/Mingw64, this works well and the commit information is reported correctly in RetroArch:

bsnes commit hash

However the same core downloaded from the buildbot does not seem to show the commit hash. Only the emulator version is displayed:

bsnes no commit

There is also a performance difference: using fast-forward, the buildbot version seems to be at least 20-30fps faster on average than the one compiled locally with Mingw on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant