Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items not backported yet #35

Open
ghost opened this issue May 13, 2023 · 9 comments
Open

Items not backported yet #35

ghost opened this issue May 13, 2023 · 9 comments

Comments

@ghost
Copy link

ghost commented May 13, 2023

  1. Replace S5b emu with emu2149 for better accuracy
    https://github.com/NovaSquirrel/Mesen-X/commits/master/Core/SSGAudio.h
    (*) Might make emu much slower on low-power devices?

  2. Replace Vrc7 emu with Nuked-OPLL
    https://github.com/NovaSquirrel/Mesen-X/commits/e6d75fcf58da2ccc1b89ed1d3c99f74925f2907e/Core/Vrc7Audio.h
    (*) Might make emu much slower on low-power devices?

  3. Ntsc filter fixes
    https://github.com/NovaSquirrel/Mesen-X/commits/master/Core/BisqwitNtscFilter.cpp

  4. HD updates (many)

@ghost
Copy link
Author

ghost commented May 14, 2023

I noticed Mesen2 has a lot of new fixes
https://github.com/SourMesen/Mesen2/commits/master/Core/NES

Possible to backport or re-fork the NES core?

@nfp0
Copy link

nfp0 commented May 15, 2023

Was #34 related to this?

@ghost
Copy link
Author

ghost commented May 16, 2023

No. NovaSquirrel/Mesen-X has lots of mapper fixes not here = #34. Post 1 has more Mesen-X changes not in libretro. And Mesen2 has newer NES fixes not seen in any Mesen1 port, which I think can be cherry-picked back here.

@nfp0
Copy link

nfp0 commented May 16, 2023

Alright, thanks for the clarification.

Hopeful that we'll get the libretro version of Mesen2 one day.

@ghost
Copy link
Author

ghost commented May 16, 2023

Sour said he will create libretro cores for each Mesen2 system but it's a long time off. And if it runs slower than Mesen1, some of us have to stick with older Mesen core.

@nfp0
Copy link

nfp0 commented May 16, 2023

Good to know he's considering the libretro cores.

But why does it run slower? I thought Mesen2 was just the continued development of the original Mesen, or is it a rewrite?

@Sanaki
Copy link

Sanaki commented May 16, 2023

Mesen is a high-accuracy emulator. The higher the accuracy, often the slower the emulation.

@negativeExponent
Copy link

copy/paste much?

@nfp0
Copy link

nfp0 commented May 17, 2023

Mesen is a high-accuracy emulator. The higher the accuracy, often the slower the emulation.

Ah yes, that makes perfect sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants