In Liblouis 3.30 release 18 Liblouisutdml Math Voluve tests are failing #106
Comments
|
@bertfrees what should we do here? These tests fail almost with every release (as the dutch tables change). Are these tests useful? |
|
Are the tests useful? There's no question about that! (Unless they are disabled with xfail.) Is it annoying that the test suite fails with almost every Dutch table update involving virtual dots? Yes. Is it annoying that Liblouisutdml is pretty much unmaintained and that it hinders smooth releasing of Liblouis in Debian? Hell yes! That said, it should be relatively easy to fix. It's probably just some character that is used in wiskunde.sem (some bracket or underscore or something) that has gotten a different virtual dot. It breaks easily also because of the way the Liblouisutdml code is written. It could be improved a lot. |
|
Bert, what the expected output braille sequence the failing tests the new changed virtual outputs related with perhaps affecting wiskunde.sem? Very interesting, when I examining after this feature merge and master branch of Liblouis UTDML cooperation with have a regression LiblouisUTDDML the test entries or not, when I setted up LOUIS_TABLEPATH environment value my /usr/src/liblouis/tables directory, I not experienced failure testcases, only when I do a full Liblouis 3.30 package. |
@hammera can you look at the test results and see if you can fix them easily? Maybe just add the virtual dots to the expected results? |
|
Ok Chris, I welcome trying investigate and fixing this issue if I get a little technical help, because I am not known detailed yet this tests how depending dutch virtual dots related with this tests, but I welcome learning new techniques. :-):-) Attila |
|
I can look at it maybe in the weekend. |
|
I think changing the underscore from 4569 to 456a might already fix it. |
|
Very thank you Bert. |
In dutch table changed the underscore virtual dot from 4569 to 456a with Liblouis 3.30 release. Without this change follow up in Liblouisutdml, 18 voluve math tests are failing. Fixes issue liblouis#106 Signed-off-by: Attila Hammer <hammera@pickup.hu>
In dutch table changed the underscore virtual dot from 4569 to 456a with Liblouis 3.30 release. Without this change follow up in Liblouisutdml, 18 voluve math tests are failing. Fixes issue liblouis#106 Signed-off-by: Attila Hammer <hammera@pickup.hu>
|
Bert, thanks the help! Works great (in Liblouis 3.30 only of course, Liblouis 3.29.0 not compatible the replacement). :-):-) Attila |
Why so? |
|
Samuel, technical some way possible doing a day basis updated liblouis-bin-git style named package with automatically updates day by day in experimental repository when happens a change the main Liblouis repository the master branch? Sorry the wrong english comment if difficulter understandable, but you sure understand what can I would like. Attila |
Daily uploads to experimental would be frowned upon :) In that case a PPA would be preferrable.
I don't think we want to rename the packages (lots of reasons including package/files exclusions that will be hard to sort out). Just appending the version number with the git date should be fine.
Similarly, a PPA with appended versions can be fine for that.
For uploads yes, but for a PPA no. |
|
Ok Samuel, everithing clear. In My Launchpad PPA I will doing this. Attila |
|
I don't know exactly how PPA works in ubuntu, but you can create a PPA on a mere webserver, you just need to build the package in the various targetted debian distributions, put them in separate directories, and run a few commands to generate the metadata |
|
I known for example with Reprepro (tryed with local system), but the interesting thing how can possible doing the automatic architectures depending builds for example i386, amd64, armhf, and ARM64 (this is the four typical architecture I think with blind users using) a mere web server when the Github Liblouis repo happens a change for example the master branch. Attila |
|
Fixed in #107 |
By first installing the |
Hi Boys,
Before I dropping a general version number update related PR to the Liblouis 3.30 version number the Liblouisutdml repository affected files (Dockerfile.win32, Dockerfile.win64, .github/workflow/main.iml, .github.workflow/sanitizer.iml), I compiled my Debian system a Liblouis 3.30 deb package and install the updated package version.
Make command ran successfull the Liblouisutdml source tree, but when I ran the test directory the make check command, I see following test-suite.log:
Me suspicious happens the failure because happened a change the virtual dots feature related, this situations always the math_voluwe tests produced failures.
Bingo. :-):-)
Following the failing tests list:
Looks the verbose tests (only the failures part):
Until this tests are not adopted the new changed tables with affects the dutch virtual dot feature change with released the Liblouis 3.30 version, impossible to increase Liblouis version number to 3.30 version, except not marks xfail flags the affected 18 testcases.
But the xfail markup is a temporary workaround only. :-):-)
Now have a dedicated maintainer the voluve tests in LiblouisUTDML?
Usual this tests are using I think the lbu_files/wiskunde.sem semantic action file and following tables, based from liblouis.ini the voluve tests main directory:
Bert, have an ydea the fix related? If I remember right you known the voluve tests hierarchy (sure better known with me). :-):-)
Samuel Don't like the mark xfail the failing tests type fixes, and will be releasing future a Liblouis version update to the 3.30 version the Debian Backports repository. :-):-)
And, a bonus:
Lot of changes happened in Liblouis side the 2023 year with based the Liblouisutdml 2.12.0 version, perhaps will be good if we doing future a fresh Liblouisutdml 3.13.0 release with contains all great new Liblouis related tables and languages (turkish table updates, new 3.30 version landed tables, etc), perhaps in jul or perhaps after the september publicated Liblouis 3.31 release.
I welcome helping this tasks related with not coding way, because me not have detailed C code experience, and active using Liblouisutdml. :-):-)
Attila
The text was updated successfully, but these errors were encountered: