You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
const output = `The pull-request PR-${{ env.PR_NUMBER }} is submitted to Gerrit [${{ inputs.ORGANIZATION }}](https://${{ env.GERRIT_SERVER }})! \n
In previous test cases, this has probably worked because vars.ORGANIZATION (set at either the ORG or REPO level in the ODL GitHub account) and the ORGANIZATION variable passed to the workflow, have both been set and are the same. I will raise a PR to fix the inconsistency.
Also, we can improve the handling of ORGANIZATION by doing the following:
In the majority of cases, this should remove the need to explicitly set the ORG name as a variable (in most cases that is already set to the required value), whilst still allowing it to be set explicitly as an input. Minimising the number of workflow inputs and setting sane default values is a good practice for us to adopt.
The text was updated successfully, but these errors were encountered:
ModeSevenIndustrialSolutions
changed the title
Mixed/confused usage of workflow invputs/variables
Mixed/confused usage of workflow inputs/variables
Oct 15, 2024
The primary workflow YAML code has a clear problem with the usage of the ORGANIZATION variable:
https://github.com/lfit/github2gerrit/blob/main/.github/workflows/github2gerrit.yaml
Here on line 267 we have:
Here on line 493 we have:
In previous test cases, this has probably worked because vars.ORGANIZATION (set at either the ORG or REPO level in the ODL GitHub account) and the ORGANIZATION variable passed to the workflow, have both been set and are the same. I will raise a PR to fix the inconsistency.
Also, we can improve the handling of ORGANIZATION by doing the following:
In the majority of cases, this should remove the need to explicitly set the ORG name as a variable (in most cases that is already set to the required value), whilst still allowing it to be set explicitly as an input. Minimising the number of workflow inputs and setting sane default values is a good practice for us to adopt.
The text was updated successfully, but these errors were encountered: