Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show command flag #135

Closed
enlewof opened this issue Oct 31, 2022 · 6 comments
Closed

Show command flag #135

enlewof opened this issue Oct 31, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@enlewof
Copy link
Contributor

enlewof commented Oct 31, 2022

Hi there,

A coworker of mine wanted a command flag to show the debug information before like the command is run. He added it to pet, but looks like pet development stalled: knqyf263/pet#142

Any chance this could be added to snipkit? Low priority of course.

Thanks.

@lemoony
Copy link
Owner

lemoony commented Oct 31, 2022

Hey,

Just to make sure I understand your proposal: You want to show the script that would be executed (like with snipkit print) and then, if it looks good to you, either execute it or abort?

@lemoony lemoony added the enhancement New feature or request label Oct 31, 2022
@enlewof
Copy link
Contributor Author

enlewof commented Nov 1, 2022

No, more like a debug mode kind of deal just in case. Like snipkit still does the exec but prints out the command it ran as well.

@lemoony
Copy link
Owner

lemoony commented Nov 1, 2022

Do yout want it printed on stdout or would the log file suffice? Printing the command to the logs if -l debug is enabled should be done either way (not as of now, but i will add it)

@enlewof
Copy link
Contributor Author

enlewof commented Nov 1, 2022

Stdout would be ideal yeah.

@lemoony
Copy link
Owner

lemoony commented Nov 17, 2022

Hi @enlewof , i've just released Version 1.4.0 with two new flags for exec: --print and --confirm.

Does this work for you?

@enlewof
Copy link
Contributor Author

enlewof commented Dec 1, 2022

Hey @lemoony I finally got around to testing this. It's pretty nice. Thank you.

@enlewof enlewof closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants