Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ipcfg utility for get-mac to find MAC addresses #216

Open
3 tasks
rtibbles opened this issue Feb 16, 2024 · 0 comments
Open
3 tasks

Switch ipcfg utility for get-mac to find MAC addresses #216

rtibbles opened this issue Feb 16, 2024 · 0 comments

Comments

@rtibbles
Copy link
Member

Observed behavior

The ipcfg library is currently unmaintained, and has issues in getting MAC addresses, especially on Windows machines where the system language is set to something other than English.

Expected behavior

We should use a maintained library that does not suffer from issues getting MAC addresses in different circumstances.

One candidate for this is https://pypi.org/project/get-mac/ a library that rather than using CLI utilities and parsing the output like ipcfg does, instead uses direct C APIs in the different OSes it supports.

Acceptance Criteria

@rtibbles rtibbles added this to the Morango v0.8.x milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant