-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /etc/default/kolibri #85
Comments
I'm |
I think that If we delete this file, kolibri-server would use the same function to calculate KOLIBRI_HOME, what's not a big problem, just a bit of code duplication. |
Am not suggesting to delete the contents. I would just move those contents unchanged to Everything that can be configured for Kolibri should be configured somewhere that is genuinely owned by the system administrator and not overwritten by package updates. We should not encourage to hack files that are maintained by the package, that's why we have
|
Hmm, I can see the point of sourcing |
Maybe let's just freeze this for later, it's not in order to fix any real issues |
Discussed with @jredrejo
We might not be benefiting from
/etc/default/kolibri
at all - the code can be moved to/etc/init.d/kolibri
which initially sources it./etc/default/kolibri
, but we still risk that they'll go and do it anyways :)I wrongfully discouraged using this file, as I have seen it change during .deb upgrades. But actually in the background info I can find on this location, people actually wanted this directory to discourage editing of the init.d scripts themselves :)
https://askubuntu.com/questions/429592/what-is-the-purpose-of-etc-default
The text was updated successfully, but these errors were encountered: