-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video downloads break when connection is unstable #5528
Comments
Hi @jiangjianshan can you post the logs here? You can do this by clicking the |
Hello @mrpau-eugene , I have found the log file inside the folder $HOME.kalite\logs. In order to upload the log files to here, the file extension have been changed from .log to .txt. django-2017-10-20.txt |
@jiangjianshan Great! Thanks a lot for the logs. However, I wasn't able to reproduce this issue.. May I also know what kind of connection are you using? Also, do you have another PC/Laptop which you can try to test it again? |
There are a lot of unhandled connection errors it seems:
|
@mrpau-eugene , My laptop was using wireless or LAN at home which it band is 20Mbit/s. Also, I have to change my hosts file in order to access google at China. @benjaoming , I have meet this issue when install and upgrade to 0.17.2, but even I latterly update to 0.17.3 but still have the same issue. So I have to wait the bug fix on the 0.17.4 release? |
@jiangjianshan I don't think it's a bug but rather a problem with China's ISP blocking some websites. Are you able to watch YouTube videos without any problems using the I'm not quite sure if we can do anything about this. Maybe @benjaoming has some ideas? |
@mrpau-eugene ,I can't watch YouTube videos even changed the hosts file. But I remember for version 0.17.1, even I can't watch the YouTube video but still can download the video by ka-lite. |
@jiangjianshan I can't seem to find any significant changes that affects downloading videos on the But just to make sure, can you try installing You can download the |
I looked through 2 of the log files and all errors are related to
This supports the description by @jiangjianshan :
@mrpau-eugene could you supply us with a URL and a video that @jiangjianshan can try out? |
@mrpau-eugene , maybe you can send the URL link of PXlvKtpvUEk.png, which one I have successfully download it by KA Lite at latest time and I can't search its URL link by www.baidu.com. Currently I can't use google because of the hosts file not work for it now. |
@jiangjianshan Here is the link for it http://s3.amazonaws.com/KA-youtube-converted/PXlvKtpvUEk.mp4/PXlvKtpvUEk.mp4 Can you try it out and see if you can watch the video? |
@mrpau-eugene , after I copy the link to URL address bar in Chrome, the video can be play. |
@jiangjianshan sorry about that.. here is the link to the thumbnail http://s3.amazonaws.com/KA-youtube-converted/PXlvKtpvUEk.mp4/PXlvKtpvUEk.png It seems like the videos you downloaded such as this one: And it seems like it is trying to download the thumbnail from
Try to access https://img.youtube.com/vi/PZM6acXvsoQ/mqdefault.jpg and I think you will have problems while accessing it.. |
@mrpau-eugene , I can download PXlvKtpvUEk.png for the link you given. But for the one from the URL link https://img.youtube.com/vi/PZM6acXvsoQ/mqdefault.jpg, as you said, I can't download it. |
@jiangjianshan Thanks for the info! I would just like to confirm if you are able to download these 2 videos: They are both available on Amazon S3. If you are able to download it, then I think the case has been resolved (?) and someone just need to update the server to include the missing videos. |
Received another report by email.. Am writing a patch now. |
@mrpau-eugene , I have just tried your suggestion but it failed to download those two videos. What I have done is firstly delete these two videos by KA Lite, and then log out and log in again. After I select them again to download. I have found they can't be download. But actually I was download it before at several months ago.
|
@benjaoming , thanks for your hard working for the patch. |
@jiangjianshan thanks for your further investigation -- at the moment, we have a pretty good idea that it's because thumb nail URLs have changed. Would you be able to try out a pre-release and confirm if it is fixed? |
@benjaoming , I'm uninstall the current version 0.17.3 and going to install the version 0.17.1. It may take several hours to install the new version and run the command "kalite manage setup" after each installation. I will report the result to you soon if I finish them. |
Sorry to hear that it takes so long to install on Windows for you. I'm not sure if this is a general issue. Anyways, I will get it reproduced and fixed -- then I will let you know when a Windows installer with the final fix is released, so you don't have to spend several hours installing to test it :)
@mrpau-richard this is a separate issue, do you have some guidance that you can refer to? Or maybe open a new installers issue that we can refer to with these sporadic reports? |
@benjaoming , it doesn't matter, I run the command "kalite manage setup" and then go to sleep. This morning I try the version 0.17.1, but got the same issue. Here is the log file. |
Sorry about the delay -- we have a slight complexity: The video download routes through LE servers, so perhaps we can fix this without a new release, but simply by patching the central server so it works for any release. Take this example:
Redirects to:
|
@benjaoming , attachment is the current log file of my ka-lite installed on my laptop. |
Sorry about the delay in solving this, am now back to the initial plan: We need to create a new release of KA Lite, because we currently don't have a proxy (the assumption in my previous comment doesn't hold). Example:
|
@benjaoming , thanks for your reply, so I have to wait for the new release 0.17.4 and then the issue should be solved. |
@jiangjianshan yes, seems so, but I will get back directly as soon as we know when it happens! |
@jiangjianshan interesting - I ran a script that downloads all thumbnails in the English database, and I had the same connection errors happen 197 times. We should fix this issue by:
I'll try to fix 1) and check if I can download all the thumbnails in one go. If successful, I will release 0.17.4. |
@benjaoming , thanks for your hard working. |
This is still not complete! There are more issues in the video download that weren't resolved in #5536 :/ |
Further robustness added in #5545 -- closing this, but in case there are further problems, we can target those in more specific issue reports. Thanks for reporting @jiangjianshan - this problem in specifically addressed in 0.17.4, which is released on PyPi, and installers will be ready in a few days. |
Hello,
My system's information is as below:
Operating system: Windows 7 Professional SP1 x64
Version: 0.17.3
Browser: Chrome
Python: 2.7.14
Recently I have my laptop can download the video via ka-lite. Every the progress bar will be block at the position very close to the end. And then the progress bar disappear.
The text was updated successfully, but these errors were encountered: