This repository has been archived by the owner on May 11, 2021. It is now read-only.

Absolute paths for referencing dependency zip will cause breakage in some deployment scenarios #11

Closed

rtibbles opened this issue Apr 20, 2021 · 1 comment

Member

rtibbles commented Apr 20, 2021

The use of this absolute URL here: https://github.com/learningequality/imscp/blob/master/src/imscp/ricecooker_utils.py#L119 could cause issues with finding the dependency zip if the zipcontent URL has been deployed not at server root.

We should change this to a relative URL instead.

Member Author

rtibbles commented May 11, 2021

Properly fixing this issue: learningequality/ricecooker#332 will supersede this issue, so closing.

rtibbles closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.