Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mshow: unknown charset of extracted attachments #248

Open
ashiire opened this issue Aug 18, 2023 · 1 comment
Open

mshow: unknown charset of extracted attachments #248

ashiire opened this issue Aug 18, 2023 · 1 comment

Comments

@ashiire
Copy link
Contributor

ashiire commented Aug 18, 2023

When extracting attachments via mshow's -x or -O flags, any present charset information is lost. This is troublesome, as charset information is difficult to infer from file contents alone.

mshow does explicitly mention attachment charset in render mode if a filter is used to render the attachment, like so:
--- --- --- 3: text/plain size=235 charset="iso-8859-2" render="mshow-plaintext" ---
However, this seems like the wrong (and inconvenient) place to recover the information from.

I have two ideas that might help:

  • (Add an option to) explicitly state charset information in list mode, if available.
  • Add an option to automatically re-encode extracted attachments to UTF-8, same as in render mode.

I think that either one would be sufficient on its own, but both may be desirable.

@leahneukirchen
Copy link
Owner

I guess the second part wouldn't be too hard to add, as all the steps are implemented already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants