Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing s_vlan before adding new one #553

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Alopalao
Copy link

@Alopalao Alopalao commented Oct 29, 2024

Closes #550

Summary

Limiting the fields for primary_path, backup_path, primary_links and backup_links. Now they will only accept this format with no additional properties/fields:

[
     {"endpoint_a": {"id": "00:00:00:00:00:00:00:01:4"},
      "endpoint_b": {"id": "00:00:00:00:00:00:00:03:3"}},
     {"endpoint_a": {"id": "00:00:00:00:00:00:00:02:3"},
      "endpoint_b": {"id": "00:00:00:00:00:00:00:03:2"}}
]

Missing to update CHANGELOG

Local Tests

Create an EVC with primary_path and a chosen s_vlan.
This is how an EVC is saved in the DB now:

  {
    _id: '72601a1d2e8b48',
    active: true,
    archived: false,
    backup_links: [],
    backup_path: [],
    bandwidth: 0,
    circuit_scheduler: [],
    creation_time: ISODate('2024-10-30T20:11:21.000Z'),
    current_path: [...],
    dynamic_backup_path: false,
    enabled: true,
    execution_rounds: 0,
    failover_path: [],
    id: '72601a1d2e8b48',
    inserted_at: ISODate('2024-10-30T20:11:21.979Z'),
    metadata: {},
    name: 'evc-vlan-100',
    primary_constraints: {},
    primary_links: [],
    primary_path: [
      {
        endpoint_a: { id: '00:00:00:00:00:00:00:01:4' },
        endpoint_b: { id: '00:00:00:00:00:00:00:03:3' }
      },
      {
        endpoint_a: { id: '00:00:00:00:00:00:00:02:3' },
        endpoint_b: { id: '00:00:00:00:00:00:00:03:2' }
      }
    ],
    queue_id: -1,
    request_time: ISODate('2024-10-30T20:11:21.000Z'),
    secondary_constraints: {},
    service_level: 0,
    start_date: ISODate('2024-10-30T20:11:21.000Z'),
    uni_a: {
      tag: { tag_type: 'vlan', value: 13 },
      interface_id: '00:00:00:00:00:00:00:01:1'
    },
    uni_z: {
      tag: { tag_type: 'vlan', value: 13 },
      interface_id: '00:00:00:00:00:00:00:02:2'
    },
    updated_at: ISODate('2024-10-30T20:11:22.077Z')
  }

End-to-End Tests

Created PR.

@Alopalao Alopalao requested a review from a team as a code owner October 29, 2024 20:27
@Alopalao Alopalao marked this pull request as draft October 30, 2024 18:31
@Alopalao Alopalao marked this pull request as ready for review October 30, 2024 20:14
@Alopalao
Copy link
Author

Applied changes requested in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

primary_path does not change its SVLAN
1 participant