Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error status to detect when an EVC had problems #511

Open
Alopalao opened this issue Sep 19, 2024 · 0 comments
Open

Add error status to detect when an EVC had problems #511

Alopalao opened this issue Sep 19, 2024 · 0 comments
Assignees

Comments

@Alopalao
Copy link

Alopalao commented Sep 19, 2024

The error Service Unavailable cannot be avoided. With enough number of requests, it will eventually happen.
This area is to deal with this and any other error while installing/deleting flows.

Sending more requests when a path fails is not ideal. Instead, we could implement a new field for the errored EVC.
error_status field will be set as:

{"error_status": {"current_path": "install", "failover_path": "delete"}}

New basic mechanic for path handling

In the case of path installation:

  1. Delete the existing path only if it exists. Avoid to send requests when there is no path.
    1.1. Path deletion errored, log error, set error in status_error, leave previous path unchanged, sync
    1.2. Return
  2. Clean up error_status
  3. Create flows and send requests to install the path
    3.1. Path deletion errored, log error, set error in status_error, set new path, sync
    3.2. Return
  4. Set new path
  5. Return

In the case of path deletion:

  1. Get the previous path to be deleted if current_path or failover_path is being deleted
    1.1.1. Path does not exist
    1.1.2. Return
  2. Create flows and send requests
    2.1. Requests errored, log error
    2.2. Raise exception EVCPathNotDeleted (New exception)
  3. Return

Additional changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant