Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a "dry run" flag to the build-push-images workflow #81

Open
sjd78 opened this issue May 15, 2024 · 1 comment
Open

Provide a "dry run" flag to the build-push-images workflow #81

sjd78 opened this issue May 15, 2024 · 1 comment
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@sjd78
Copy link
Member

sjd78 commented May 15, 2024

Add a "dry run" flag to the build-push-images workflow to enable image build but skip the push to repo. This feature would allow reuse of the full build-push-images workflow in as a test to make sure that image builds will work with a change in a given PR.

Ref: konveyor/tackle2-ui#1907 (comment)

This is in support of the workflow created in konveyor/tackle2-ui#1907 that implements basic CI for Dockerfile and package-lock.json file changes to go along with dependabot docker image tracking konveyor/tackle2-ui#1883.

By adding the flag, the test-image-build job of the tackle2-ui workflow https://github.com/konveyor/tackle2-ui/blob/f501fb80f50830a9437db27460ccd315329e793e/.github/workflows/ci-image-build.yml#L69-L105 could be replaced with a call to build-push-images and ensure the test build and the actual build-push are using the same steps.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 15, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant