Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes component_name variable accessible for example generator #159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Makes component_name variable accessible for example generator #159

wants to merge 2 commits into from

Conversation

kinduff
Copy link

@kinduff kinduff commented Dec 12, 2019

Closes #158

Not sure if this is the right approach or if we can simply use @component.id for the call.

Let me know if this is okay.

@Spone
Copy link
Collaborator

Spone commented Dec 12, 2019

Thank you for contributing! Your approach makes sense, I'm not sure if there is a simpler way. What do you think @nicolas-brousse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spone Spone Spone approved these changes

@nicolas-brousse nicolas-brousse Awaiting requested review from nicolas-brousse

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined local variable or method `component_name'
2 participants
@kinduff @Spone