Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

komponent:install doesn't work with Rails 6 #149

Open
nicolas-brousse opened this issue Oct 9, 2019 · 2 comments
Open

komponent:install doesn't work with Rails 6 #149

nicolas-brousse opened this issue Oct 9, 2019 · 2 comments
Labels
bug generator
Milestone
2.3

Comments

@nicolas-brousse
Copy link
Member

nicolas-brousse commented Oct 9, 2019 •
edited
Loading

komponent:install generator doesn't work correctly with Rails 6.

$ rails new test_app
...
$ bundle add komponent
...
$ rails generate komponent:install
Running via Spring preloader in process 14410
      create  frontend
        gsub  config/webpacker.yml
      create  frontend/components
      create  frontend/components/index.js
      append  frontend/packs/application.js
The file /Users/nicolas/Projects/_tmp/test_app/frontend/packs/application.js does not appear to exist
@nicolas-brousse
Copy link
Member Author

nicolas-brousse commented Oct 10, 2019 •
edited
Loading

It has been fixed in d8f3be9.

Fix is present in v3.0.0.beta1 but not in v2.2.0.

May we backport the fix in v2.2.1? Or we wait for v3.0.0 release?

@Spone
Copy link
Collaborator

Spone commented Oct 10, 2019 •
edited
Loading

Feel free to backport it, then we can release a 2.2.1 version

@Spone Spone added this to the 2.3.0 milestone Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug generator
Milestone
2.3
Development

No branches or pull requests
2 participants
@Spone @nicolas-brousse