Pet unable to create new snippet if SnippetFile attribute in config is omitted

[csessh]

While doing some tests for #320, this came up:

Pet raised exception when SnippetFile attribute is omitted (as per https://github.com/knqyf263/pet/blob/main/README.md#multi-directory-and-multi-file-setup)

Here's how to reproduce:

1- Fresh install

fw13 :: ~/Documents/pet ‹feat-syspath*› » pet version
pet version 0.9.0

2- Config file:

[General]
...
SnippetDirs = ["~/.config", "~/.config/test"]
# SnippetFile = "/var/tmp/pet/snippet.toml"
...

3- Pet new

Expected result:

fw13 :: ~/Documents/pet ‹feat-syspath*› » pet new                                  
Command>  

Actual result:

fw13 :: ~/Documents/pet ‹feat-syspath*› » pet new
panic: Error reading snippet file

goroutine 1 [running]:
github.com/knqyf263/pet/cmd.countSnippetLines()
	/home/runner/work/pet/pet/cmd/new.go:172 +0x78
github.com/knqyf263/pet/cmd.new(0xe184a0?, {0xe51c88, 0x0, 0x0})
	/home/runner/work/pet/pet/cmd/new.go:193 +0x73
github.com/spf13/cobra.(*Command).execute(0xe184a0, {0xe51c88, 0x0, 0x0})
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:762 +0x67c
github.com/spf13/cobra.(*Command).ExecuteC(0xe18960)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:852 +0x2e5
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:800
github.com/knqyf263/pet/cmd.Execute()
	/home/runner/work/pet/pet/cmd/root.go:48 +0x25
main.main()
	/home/runner/work/pet/pet/main.go:20 +0x17

Note: This yields the same result

SnippetDirs = ["~/.config", "~/.config/test"]
SnippetFile = ""

[csessh]

There's a check missing here:

pet/cmd/new.go

Line 170 in 56b43be

f, err := os.Open(config.Conf.General.SnippetFile)

I think that's about it

[csessh]

@RamiAwar
I think this should be created as its own issue/bug report.

Apart from the check for omitting SnippetFile attribute that causing panic, I don't think it's doing what README.md says it does.

First: new snippet files are created based on command description, not time based.

// Save saves the snippets to toml file.
func (snippets *Snippets) Save() error {
	var snippetFile string
	var newSnippets Snippets

	for _, snippet := range snippets.Snippets {
		if snippet.Filename == "" {
			snippetFile = config.Conf.General.SnippetDirs[0] + fmt.Sprintf("%s.toml", strings.ToLower(sanitize.BaseName(snippet.Description)))
			newSnippets.Snippets = append(newSnippets.Snippets, snippet)
		} else if snippet.Filename == config.Conf.General.SnippetFile {
			snippetFile = config.Conf.General.SnippetFile
			newSnippets.Snippets = append(newSnippets.Snippets, snippet)
		}
	}

...

Secondly, new snippet file created this way (using directory and omitting snippet file attribute) will duplicate previously added commands.

Here's an example:

SnippetDirs = ["~/.config/pet/"]
SnippetFile = ""

fw13 :: ~/Documents/pet ‹feat-syspath*› » go run main.go new      
Command> "~/.config/pet/", SnippetFile omitted
Description> Test #1
fw13 :: ~/Documents/pet ‹feat-syspath*› » go run main.go edit
fw13 :: ~/Documents/pet ‹feat-syspath*› » cat ~/.config/pet/test-1.toml 

   1   │ 
   2   │ [[Snippets]]
   3   │   Description = "Test #1"
   4   │   Filename = ""
   5   │   Output = ""
   6   │   Tag = []
   7   │   command = "\"~/.config/pet/\", SnippetFile omitted"

This is fine. Similarly, creating another snippet and we get:

fw13 :: ~/Documents/pet ‹feat-syspath*› » cat ~/.config/pet/test-2.toml 

   1   │ 
   2   │ [[Snippets]]
   3   │   Description = "Test #1"
   4   │   Filename = "/home/csessh/.config/pet/test-1.toml"
   5   │   Output = ""
   6   │   Tag = []
   7   │   command = "\"~/.config/pet/\", SnippetFile omitted"
   8   │ 
   9   │ [[Snippets]]
  10   │   Description = "test #2"
  11   │   Filename = ""
  12   │   Output = ""
  13   │   Tag = []
  14   │   command = "relative path, no snippetfile"

Test 1 command shouldn't be present in test-2.toml, I believe.