Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Serving conformance tests with HPA #50

Open
skonto opened this issue Sep 10, 2024 · 1 comment
Open

Add Serving conformance tests with HPA #50

skonto opened this issue Sep 10, 2024 · 1 comment

Comments

@skonto
Copy link
Contributor

skonto commented Sep 10, 2024

  • Make sure everything passes
  • Should be a separate test suite
@skonto
Copy link
Contributor Author

skonto commented Sep 19, 2024 •
edited
Loading

Most tests seem to run fine when setting pod-autoscaler-class: hpa.autoscaling.knative.dev in autoscaler cm, with the default metric=cpu and patching tests with the right pod resource requests (needed by HPA). Rrror_condition, and resources tests need some adjustment but also should pass. I will create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skonto