Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way/instructions on how to use with figwheel-main instead of shadow-cljs #8

Open
stathissideris opened this issue Jun 15, 2021 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@stathissideris
Copy link

No description provided.

@kiranshila
Copy link
Owner

So, I think the story is that the :npm-deps in deps.cljs work fine, as in cljs knows to grab the node deps, but it still needs the externs. The :require statements in the various places I use the node modules are Shadow specific, so I'm not quite sure how to make them do nothing for non-shadow builds.

The other half of the story is none of remark + plugins I need are on CLJSJS, so we would need to manually go in there and generate all of those externs.

@kiranshila kiranshila added bug Something isn't working help wanted Extra attention is needed labels Jun 18, 2021
@kiranshila
Copy link
Owner

Now that our cljs requires are using the modern $default syntax, this should be able to work with cljsjs dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants