feat(planner): add ability to check-off steps #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Impatiently pinging @seirl because it's almost Wednesday and time for another run 👀 😅 |
|
now wait untill someone comes along to add it please someone add this this to the website already >_< |
|
Yeah, I got bored of waiting for this PR to land, so I build my own planner with this feature 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hihi,
Started using SA again recently while waiting for SL to drop, so decided to contribute back to it. Been a long time since I touched AngularJS, so bear with me 😄
New
mountRunsdirective to handle common presentation and logic of planner tablesplannerStepHasRunto perform filtering on planner step based on newhasRunboolChanges
MountsCtrlto remove large amount of code migrated tomountRunsdirectivehasRunbool to planner steps for handling user-determined completion of stepvisualIndexto planner steps to preserve "Step #" as it moves between complete/incomplete stateIn the future, I'd hope to expand this with
localStorageto preserve progress through sessions and page reloads, but I wouldn't like this PR getting much larger than it isCloses #249
Closes #267