Skip to content

Latest commit

 

History

History
223 lines (215 loc) · 8.69 KB

TODO.md

File metadata and controls

223 lines (215 loc) · 8.69 KB
Raw

  • Investigate Rollbar breaks:

    • ie11 crashes

      • wow, people use this

    • Uncaught SyntaxError: Unexpected token =>

      • Samsung Internet 12.1

    • Script Error

      • Samsung Internet 12.1

    • Attempt to use history.replaceState() more than 100 times per 30 seconds

      • ios 14

  • armoryinfo returns all locals, might want to trim that to save size?

  • seems like I lost events in ga

  • take a look at percy.io

  • use race-id and gender-id as a fallback for char image

  • prob need to do another update for all the wowhead hover states

  • see how expensive removing unused bootstrap css

Punted for now

  • split out css overrides so they sit next to components/views
  • Update bootstrap version

Finished

  • services
    • profile
    • achievements
    • mount
    • realms
    • factions
    • companions
    • battle pets
    • toys
    • planner
  • views
    • header
      • fix blink when navigating
    • login
      • verification/disable ok if not valid server
      • servers
        • test delayed json load and rendering
        • figure out container style vs container class
        • should autofocus on page load
        • focus border on input
        • focus color
        • no options - change text to something more appropriate
        • padding
        • chevron
        • typing adjustments?
        • padding for once selected
    • achievements
    • overview
    • mount
    • battle pets
    • companions
    • calendar
    • toys
    • reps
    • planner
      • ability to deep link
      • special view for 0 left - success kid
  • don't change all user params when not needed
    • img profile blinks when I navigate around site
    • had to switch from obj in store to individual props, worked way better
  • root should route to login or #/
  • overview css got messed up
  • overview only animates global and not individual
  • hookup wowhead.js
  • title proper
  • implement dark/light theme work based on preferences
    • persist theme
    • test all pages and compare
    • see app.html and localStorage
    • fix select control to have overrides like the rest
  • BUG: if I go to login page, i get back screen that is black, if I then change url to a page that doesn't have login, screen stays black
    • fixed when I switched to not using modal scripts
  • getrid of bootstrap runtime
    • any easy way to not have to load jquery and bootstrap to pop open this?
    • currently needed for modal, not sure what else
  • fix in body, did I do this wrong?
  • logox2 wired up?
  • still need other static images?
  • move _utils to other utils class
  • move majors stuff to a Pages folder
  • rename _settings to settings
  • move nav to components
  • move planner to components?
  • rename global2.css to global.css
  • $error.svelte - good with the one that it shipped with
  • better way to do navigation menus using for-loop?
  • cleanup menu collapse
  • add google analytics
  • add api caching
  • Placeholder in select while loading so its not totally collapsed
    • maybe just default size the box, or total fixed size on the box
  • Disable next button in calendar when at end
  • Disable previous in calendar when at beginning
  • search for 'ng-'
  • search for TODO
  • move getImageSrc to common
  • [] 1x1 image to common
  • add event listener for prefers-color-scheme change
  • clear cache when user changes - !doh
  • handle profile error from bad character
    • what should the ui be?
    • handle profile
    • handle profile media
    • add analytics
  • check: when there is a character error, does the url listener get busted so it can't be fixed?
  • TODO: need to test neutral race stuff
  • get it building in production mode
    • fix Svelte-Select include problem and put it back
      • hack, had to copy it into source tree
    • put back $error
    • fix path includes
    • build it
      • fix build error: Cannot read property 'id' of null
    • update to new kit?
    • adapt it
    • deploy sample
  • BUG: change achievement category, it doesn't update the boxes
  • BUG: planner has an error in console
  • BUG: toys save didn't seem to work
    • refresh did though, probably cache issue
  • double check meta tags used versus old
  • test on mobile click handling of menu items
    • seems to be working
  • how will we handle cache busting?
    • working for the most part, but need to move global styles into a import so it is calculated in a hash
    • not needed, looked into it further, netlify is doing etag expiring so that works.
  • handle special case where user gets an error, then just changes the url but it still contains, /error/ at the beginning and they don't notice
  • hitting the back button will also send you back and then back to the error page, ugh
  • add spinner for loading to stuff, which was a longtime ask
  • NIT: getting two slashes during login /#//
  • [] service worker for resources to make it faster
    • punted, didn't want the complication
  • PWA
  • fix lighthouse accessibility failures
    • login
    • page
  • test all pages for missing icons
  • test all pages for perf
    • just do lighthouse scores comparing both for
      • desktop - login and mounts time to interactive: 1.8s -> .7s first contentful paint: .7s -> .4s
      • mobile - login and mounts time to interactive: 7.3s -> 2.5s
    • downloads: login old: 17 requests, 848 kB, finish: 548ms, Load: 551ms login new: 17 requests, 578 kb, finish: 457ms, Load: 366ms mounts old: 281 requests, 1.7MB, Finish: 2.12s, Load: 374 ms mounts new: 279 requests, 1.3MB, Finish: 1.93s, Load: 269 ms
  • [] PERF: Add to wowhead links, rel="noopener"
  • BUG: capitalize character and server in profile dropdown
  • PERF: Set an explicit width and height on image elements to reduce layout shifts and improve CLS
    • Profile
    • Achieve/Mounts/Other
  • Browser automation?
    • test visual diff from older site
    • compare perf to older site
    • compare asset size to other site
  • FEATURE: load user from localstorage?
    • switch user/logout in profile dropdown?
    • when navigate to login screen, clear local storage
  • BUG: PWA: some weirdness when set to darkmode
    • seems to be working fine now that its all dialed in
  • Login Enhancements
    • any easy way to implement highlight like old model?
    • [] can I implement a better filter to match what I had?
    • onEnter should focus next input
    • doesn't auto select first result
      • this is a bug in the control where if first item is a group header it doesn't work properly
    • BUG: can't reselect same selected item
    • tab doesn't seem to work on safari
    • width fix
  • Prep to check-in
  • URL encoding error in the profile: "Signed in as Ana%C3%Bfza @ Archimonde"
  • selecting text in the profile modal closes the window
  • [] There seems to be a weird race condition in the realm selection, when I type "arc really fast it sometimes selects Aegwynn.
    • not repro, tried bunch of browsers and slowdown
  • BUG: LOGIN: type 'ARC' very fast. Improperly selects 'Aegwynn'
  • BUG: LOGIN: type 'ARC' very fast, throws a script error
  • BUG: LOGIN: "enter" doesn't submit the character selection form?
  • Seeing multiple loglines when navigating
    • Updating local storage user to us.proudmoore.marko...
    • investigate if expected or doing too much work
  • update error page to include blurb about privacy
  • Cannot read property forEach of undefined/null expression