Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: enable 0 gas price blocks #405

Open
apoorvsadana opened this issue Oct 14, 2024 · 0 comments
Open

bug: enable 0 gas price blocks #405

apoorvsadana opened this issue Oct 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@apoorvsadana
Copy link
Contributor

SNOS version:

3bd95bf

Current behavior:

Running a block with gas_price 0 panics over here as it expects the price to be > 1.

Expected behavior:

It's possible to have a 0 gas price if

  1. The chain is just starting up. The fee token isn't deployed at this point and you need to setup using 0 gas fees. For example, check first tx of Sepolia here.
  2. The app chain just wants to run without any fees
  3. We don't have a custom fee token like strk so those prices are 0 (will need to check how do V3 txs work here).

Steps to reproduce:

It's a little hacky to do it right now, at least the way I did it

  1. Run Madara in devnet
  2. Connect pathfinder to this Madara
  3. Create blocks with 0 fees
  4. Run SNOS

However, once the <10 block issue is fixed maybe we can run it on blocks from 0-5 on Sepolia, it will be easier.

Related code:

eth_l1_gas_price: felt_to_u128(&block.l1_gas_price.price_in_wei).try_into().unwrap(),

@apoorvsadana apoorvsadana added the bug Something isn't working label Oct 14, 2024
@apoorvsadana apoorvsadana changed the title bug: enable 0 gas price proving bug: enable 0 gas price blocks Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant