bug: retdata is not a Relocatable

[whichqua]

Affected blocks

This issue can be observed in the following blocks:

• 160079
• 160033

Background

• This issue seems to specifically affect deploy syscalls called in an invoke transaction.
• It occurs in this hint:

pub const CHECK_NEW_DEPLOY_RESPONSE: &str = indoc! {r#"
	# Check that the actual return value matches the expected one.
	expected = memory.get_range(
	    addr=ids.response.constructor_retdata_start,
	    size=ids.response.constructor_retdata_end - ids.response.constructor_retdata_start,
	)
	actual = memory.get_range(addr=ids.retdata, size=ids.retdata_size)
	assert expected == actual, f'Return value mismatch; expected={expected}, actual={actual}.'"#
};

• The issue seems to constructor_args being an empty vector.

Next steps

• Write integration tests covering deploy_contact syscall in an invoke transaction.
• Attempt to do a deploy with empty args?

[whichqua]

This test was added to the test_contract.cairo via this commit.

    #[external(v0)]
    fn test_deploy_no_calldata(
        self: @ContractState,
        class_hash: ClassHash,
        contract_address_salt: felt252,
        deploy_from_zero: bool,
    ) {
        let calldata: Array::<felt252> = Default::default();
        syscalls::deploy_syscall(
            class_hash, contract_address_salt, calldata.span(), deploy_from_zero
        )
            .unwrap_syscall();
    }

This test fails showing there is an issue when handling deploying contracts without constructor_call_data.