Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On windows, the subProcess kill logic was causing EPERM issues as it was trying to kill an already dead process #44

Open
jglanz opened this issue Aug 18, 2024 · 1 comment

Comments

@jglanz
Copy link

jglanz commented Aug 18, 2024

On windows, the subProcess kill logic was causing EPERM issues as it was trying to kill an already dead process

NOTE: the patch is on the compiled library, just thought I'd mention ;)

Below patch was generated via directly hacking the RPCProcess (with patch-package), but it should be fairly close to a final remedy
@kayahr+jest-electron-runner+29.14.0.patch

Other than that, great work.

@kayahr
Copy link
Owner

kayahr commented Aug 18, 2024

Do you have some reproduction instructions? I use jest-electron-runner in many projects which are also used by windows developers and I never heard about this problem.

Checking the killed flag before killing the process sounds reasonable, I can apply this. But I don't understand the second change in your patch. Instead of killing the process group (negative PID) it now kills the process twice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants