Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lily58 Pro footprint issues #31

Open
Maarrk opened this issue Sep 29, 2021 · 3 comments
Open

Lily58 Pro footprint issues #31

Maarrk opened this issue Sep 29, 2021 · 3 comments

Comments

@Maarrk
Copy link

Maarrk commented Sep 29, 2021

When ordering manufacturing of the Pro PCBs, I ran into some issues:

  • the MX hotswap socket holes have a 0.1mm hole inside them which shouldn't be there (see screenshot)
  • all footprints reference Lily58-footprint library instead of Lily58_Pro-footprint
  • the switch footprints reference CherryMX_KailhLowProfile_Hotswap_Edge, I guess they should be MX_Choc_Hotswap from the Pro library

The issue with the extra holes is most severe, because having holes smaller than 0.3mm in the drill file raises cost of PCB manufacturing. Even though they don't actually make sense, since they are inside bigger holes.

I don't know how the footprint libraries got so mixed up. If you don't have it sorted on your machine waiting to be commited, I'd be happy to submit a PR.

extra hole

@sungo
Copy link

sungo commented Jun 12, 2022

@Maarrk since you've not gotten a response here, can I talk you into tossing the repaired kicads up someplace?

@Maarrk
Copy link
Author

Maarrk commented Jun 13, 2022

@sungo I'm sorry, but I don't have these anymore. I'd need to start from scratch, and now I'm already on KiCad 6...

Should've just done the PR right away 😢

@sungo
Copy link

sungo commented Jun 13, 2022

@Maarrk no worries. Thanks for pointing out the issues. I'm glad to not get caught unaware and I need to learn kicad anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants