Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Terminal works with colors out of the box #372

Open
certik opened this issue Oct 16, 2024 · 2 comments
Open

Windows Terminal works with colors out of the box #372

certik opened this issue Oct 16, 2024 · 2 comments

Comments

@certik
Copy link
Collaborator

certik commented Oct 16, 2024

We still need special handling to turn the terminal into "raw" mode, but for only printing colors and using other escape codes, we do not need any special setup on Windows anymore.

I don't have an opinion if we need to still support the old "Console", or if just supporting the new "Terminal" is enough.

@flagarde
Copy link
Collaborator

flagarde commented Oct 16, 2024

@certik What do you mean to deal with raw mode? I think this function is already provided by the library right?

For the old console there is workaround but I don't know it if worth it and I have spend time on something that seems more needed for me. See: https://github.com/flagarde/cpp-terminfo

Still some works to do but it will allow to have access to all terminfo data inside shared library .so and as such be independent of terminfo database and program.

I guess this library could be included by fetchcontent to this repo? @certik what do you think about this. I think it is important because for now we are hard coding the escape code for colors keys etc but each terminal have some specialties that's why ncurse etc use terminfo library for this.

@certik
Copy link
Collaborator Author

certik commented Oct 17, 2024

Yes, cpp-terminal indeed provides everything already. My point is that maybe we don't need some of the functionality anymore, since it was needed only for the old Windows Console, if we decide we don't need to support it.

When I built this library, my idea was that all modern terminals essentially require almost the same handling, so that we do not need to differentiate. If however different terminals require different handling, as you suggest, then indeed we need some kind of a database, like the one you created. Do you have time to meet over video to discuss the details and how to move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants