Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosing Black Icons doesn't update Retina Display reference #109

Open
nightbook opened this issue Sep 8, 2012 · 2 comments
Open

Choosing Black Icons doesn't update Retina Display reference #109

nightbook opened this issue Sep 8, 2012 · 2 comments

Comments

@nightbook
Copy link

Selecting Black as Icon updates only 3 of the 4 image references resulting in white icons on Retina Display devices (iPhone4/Android).

From a theme.css
/* HD/"retina" sprite
-----------------------------------------------------------------------------------------------------------*/

@media only screen and (-webkit-min-device-pixel-ratio: 1.5),
only screen and (min--moz-device-pixel-ratio: 1.5),
only screen and (min-resolution: 240dpi) {

.ui-icon-plus, .ui-icon-minus, .ui-icon-delete, .ui-icon-arrow-r,
.ui-icon-arrow-l, .ui-icon-arrow-u, .ui-icon-arrow-d, .ui-icon-check,
.ui-icon-gear, .ui-icon-refresh, .ui-icon-forward, .ui-icon-back,
.ui-icon-grid, .ui-icon-star, .ui-icon-alert, .ui-icon-info, .ui-icon-home, .ui-icon-search, .ui-icon-searchfield:after, 
.ui-icon-checkbox-off, .ui-icon-checkbox-on, .ui-icon-radio-off, .ui-icon-radio-on {
    background-image: url(images/icons-36-white.png);
    -moz-background-size: 776px 18px;
    -o-background-size: 776px 18px;
    -webkit-background-size: 776px 18px;
    background-size: 776px 18px;
}
.ui-icon-alt {
    background-image: url(images/icons-36-black.png);
}

}

Note both background-image urls should point to icons-36-black.png however the first still refers to icons-36-white.png

@jaspermdegroot
Copy link
Member

@nightbook - What version of JQM do you use?

@tybenz - Hi Tyler! Haven't test it myself but sounds like old issue is back (#79).

@nightbook
Copy link
Author

@uGoMobi I rolled a JQM 1.1.1 but believe it also affected 1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants