Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzer rule for disallowing readonly fields with QueryAttribute or ProvideAttribute #111

Merged
merged 4 commits into from
Sep 26, 2023

chore(analyzers): enable release tracking analyzer

a800f5d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Add analyzer rule for disallowing readonly fields with QueryAttribute or ProvideAttribute #111

chore(analyzers): enable release tracking analyzer
a800f5d
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results completed Sep 26, 2023 in 0s

✅ Test Results - 112/112 - Passed in 45.540s

✅ editmode-results.xml - 19/19 - Passed in 43.776s

✅ playmode-results.xml - 93/93 - Passed in 1.764s

Details

✅ editmode-results.xml - 19/19 - Passed in 43.776s
  • ✅ UIComponents.Benchmarks.AssetLoading.AddressablesAssetLoadBenchmarks - 2/2 - Passed in 7.677s
    • InitializeComponentWithColdCache - Passed in 3.801s
    • InitializeComponentWithWarmCache - Passed in 3.875s
  • ✅ UIComponents.Benchmarks.AssetLoading.AssetDatabaseAssetLoadBenchmarks - 2/2 - Passed in 4.213s
    • InitializeComponentWithColdCache - Passed in 2.181s
    • InitializeComponentWithWarmCache - Passed in 2.032s
  • ✅ UIComponents.Benchmarks.AssetLoading.ResourcesAssetLoadBenchmarks - 2/2 - Passed in 9.469s
    • InitializeComponentWithColdCache - Passed in 4.551s
    • InitializeComponentWithWarmCache - Passed in 4.918s
  • ✅ UIComponents.Benchmarks.UIComponentInitBenchmarks - 4/4 - Passed in 14.883s
    • InitializeComponentWithDependencyWithColdCache - Passed in 3.051s
    • InitializeComponentWithDependencyWithWarmCache - Passed in 3.338s
    • InitializeEmptyComponentWithColdCache - Passed in 3.989s
    • InitializeEmptyComponentWithWarmCache - Passed in 4.506s
  • ✅ UIComponents.Tests.Editor.AssetDatabaseAssetResolverTests - 2/2 - Passed in 0.075s
    • Should_Be_Able_To_Load_Existing_Asset - Passed in 0.040s
    • Should_Be_Able_To_Tell_If_Asset_Exists - Passed in 0.035s
  • ✅ UIComponents.Tests.Editor.Interfaces.UIComponentInterfaceTests - 7/7 - Passed in 7.257s
    • IOnAttachToPanel_Registers_AttachToPanelEvent_Callback - Passed in 2.181s
    • IOnClick_Registers_ClickEvent_Callback - Passed in 0.953s
    • IOnDetachFromPanel_Registers_DetachFromPanelEvent_Callback - Passed in 0.688s
    • IOnGeometryChanged_Registers_GeometryChangedEvent_Callback - Passed in 1.029s
    • IOnMouseEnter_Registers_MouseEnterEvent_Callback - Passed in 0.690s
    • IOnMouseLeave_Registers_MouseLeaveEvent_Callback - Passed in 1.029s
    • IOnMyCustomEvent_Registers_MyCustomEvent_Callback - Passed in 0.687s
✅ playmode-results.xml - 93/93 - Passed in 1.764s
  • ✅ UIComponents.Tests.DebugLoggerTests - 3/3 - Passed in 0.109s
    • Log_Uses_Debug_Log - Passed in 0.104s
    • LogError_Uses_Debug_LogError - Passed in 0.003s
    • LogWarning_Uses_Debug_LogWarning - Passed in 0.002s
  • ✅ UIComponents.Tests.DependencyConsumerTests - 6/6 - Passed in 0.015s
    • Concrete_Dependencies_Are_Provided - Passed in 0.007s
    • DependencyConsumers_Have_No_Dependencies_By_Default - Passed in 0.002s
    • TestBed_Works_With_DependencyConsumers - Passed in 0.002s
    • The_Correct_Class_Is_Provided_To_EmptyStringDependencyConsumer - Passed in 0.001s
    • The_Correct_Class_Is_Provided_To_StringDependencyConsumer - Passed in 0.000s
    • TryProvide_Works_For_EmptyStringDependencyConsumer - Passed in 0.002s
  • ✅ UIComponents.Tests.DependencyInjectorTests - 2/2 - Passed in 0.161s
    • Can_Be_Created_Using_Consumer - Passed in 0.159s
    • Can_Be_Created_Without_Consumer - Passed in 0.002s
  • ✅ UIComponents.Tests.DependencyInjectorTests+Provide - 3/3 - Passed in 0.011s
    • Returns_Desired_Dependency - Passed in 0.002s
    • Returns_Transient_Dependency_If_Singleton_And_Transient_Are_Registered - Passed in 0.001s
    • Throws_If_No_Provider_Exists - Passed in 0.008s
  • ✅ UIComponents.Tests.DependencyInjectorTests+SetConsumer - 1/1 - Passed in 0.002s
    • Refreshes_Transient_Dependencies - Passed in 0.002s
  • ✅ UIComponents.Tests.DependencyInjectorTests+SetTransientInstance - 1/1 - Passed in 0.001s
    • Switches_A_Transient_Instance - Passed in 0.001s
  • ✅ UIComponents.Tests.DependencyInjectorTests+TryProvide - 2/2 - Passed in 0.002s
    • Returns_If_Dependency_Could_Be_Provided - Passed in 0.001s
    • Yields_Null_If_Dependency_Can_Not_Be_Provided - Passed in 0.001s
  • ✅ UIComponents.Tests.DependencyTests - 7/7 - Passed in 0.011s
    • Allows_Creating_An_Instance - Passed in 0.001s
    • Allows_Fetching_Dependency_Type - Passed in 0.000s
    • Allows_Fetching_Implementation_Type - Passed in 0.000s
    • Allows_Fetching_Scope - Passed in 0.003s
    • Constructor_Throws_On_Null_Factory - Passed in 0.006s
    • SingletonFor_Returns_Singleton_Scope - Passed in 0.000s
    • TransientFor_Returns_Transient_Scope - Passed in 0.000s
  • ✅ UIComponents.Tests.DiContextTests - 5/5 - Passed in 0.016s
    • Allows_Changing_Current_Context - Passed in 0.000s
    • Allows_Checking_Whether_An_Initialized_Injector_Exists - Passed in 0.013s
    • Allows_Getting_Singleton_Instances - Passed in 0.000s
    • Allows_Resetting_Context - Passed in 0.002s
    • Does_Not_Allow_Changing_To_Null_Context - Passed in 0.001s
  • ✅ UIComponents.Tests.DiContextTests+GetInjector - 3/3 - Passed in 0.002s
    • It_Creates_A_New_Injector_If_One_Does_Not_Exist - Passed in 0.001s
    • It_Throws_If_Consumer_Type_Is_Null - Passed in 0.001s
    • It_Yields_Existing_Injector - Passed in 0.000s
  • ✅ UIComponents.Tests.DiContextTests+RegisterConsumer - 1/1 - Passed in 0.001s
    • It_Populates_Singleton_Instances - Passed in 0.001s
  • ✅ UIComponents.Tests.LayoutAttributeTests - 4/4 - Passed in 0.107s
    • Given_Layout_Is_Loaded - Passed in 0.069s
    • Null_Layout_Is_Handled - Passed in 0.010s
    • Superclass_Layout_Is_Loaded_If_It_Is_Not_Overridden - Passed in 0.013s
    • Superclass_Layout_Is_Not_Loaded_If_Overridden - Passed in 0.014s
  • ✅ UIComponents.Tests.ProvideAttributeTests - 4/4 - Passed in 0.008s
    • Allows_Providing_Dependencies_With_A_Cast - Passed in 0.004s
    • Logs_Error_On_Invalid_Cast - Passed in 0.002s
    • Logs_Error_When_Provider_Is_Missing - Passed in 0.001s
    • Provides_Dependencies_Automatically - Passed in 0.001s
  • ✅ UIComponents.Tests.QueryAttributeTests - 4/4 - Passed in 0.273s
    • Should_Log_Errors_If_Query_Yields_No_Results - Passed in 0.044s
    • Should_Not_Populate_Invalid_Fields - Passed in 0.191s
    • Should_Populate_Fields - Passed in 0.021s
    • Should_Populate_Inherited_Fields - Passed in 0.017s
  • ✅ UIComponents.Tests.QueryClassAttributeTests - 9/9 - Passed in 0.174s
    • Creates_Empty_List_And_Array_If_No_Elements_Are_Found - Passed in 0.097s
    • Leaves_Field_Null_If_No_Element_Is_Found - Passed in 0.010s
    • Populates_Array_With_All_Elements_With_Class - Passed in 0.009s
    • Populates_Array_With_All_Elements_With_Multiple_Classes - Passed in 0.009s
    • Populates_List_With_All_Elements_With_Class - Passed in 0.009s
    • Populates_Single_Element_With_First_Element_With_Class - Passed in 0.011s
    • Populates_Typed_Array_And_List_With_Elements_Of_Type_And_Class - Passed in 0.012s
    • Populates_Typed_Array_With_Multiple_Classes - Passed in 0.008s
    • Works_With_Both_Name_And_Class_Query - Passed in 0.009s
  • ✅ UIComponents.Tests.ResourcesAssetResolverTests - 2/2 - Passed in 0.041s
    • Should_Be_Able_To_Load_Existing_Asset - Passed in 0.021s
    • Should_Be_Able_To_Tell_If_Asset_Exists - Passed in 0.021s
  • ✅ UIComponents.Tests.RootClassAttributeTests - 2/2 - Passed in 0.028s
    • Adds_Class_To_Component - Passed in 0.014s
    • Adds_Class_To_Component_And_Child_Component - Passed in 0.014s
  • ✅ UIComponents.Tests.StylesheetAttributeTests - 3/3 - Passed in 0.046s
    • Given_Stylesheets_Are_Loaded - Passed in 0.019s
    • Inherited_Stylesheets_Are_Loaded - Passed in 0.013s
    • Invalid_Stylesheets_Output_Error_Message - Passed in 0.014s
  • ✅ UIComponents.Tests.TestBedTests - 6/6 - Passed in 0.012s
    • Allows_Changing_Singleton_Instance - Passed in 0.002s
    • Allows_Creating_Component_With_Singleton_Dependencies - Passed in 0.002s
    • Allows_Creating_Component_With_Transient_Dependencies - Passed in 0.001s
    • Allows_Fetching_Dependencies - Passed in 0.001s
    • Allows_Passing_Constructor_Arguments - Passed in 0.003s
    • Works_On_Non_UIComponent_Type - Passed in 0.002s
  • ✅ UIComponents.Tests.UIComponentDependencyTests - 5/5 - Passed in 0.006s
    • A_Missing_Dependency_Can_Be_Handled_With_TryProvide - Passed in 0.002s
    • Concrete_Dependencies_Are_Provided - Passed in 0.002s
    • The_Correct_Class_Is_Provided_To_Component - Passed in 0.001s
    • The_Correct_Class_Is_Provided_To_Component_When_Overridden - Passed in 0.001s
    • Transient_Dependencies_Are_Not_Cached - Passed in 0.001s
  • ✅ UIComponents.Tests.UIComponentEffectAttributeTests - 1/1 - Passed in 0.014s
    • Effects_Are_Sorted_By_Priority - Passed in 0.014s
  • ✅ UIComponents.Tests.UIComponentNoAttributesTests - 2/2 - Passed in 0.009s
    • No_Layout_Is_Loaded - Passed in 0.005s
    • No_Styles_Are_Loaded - Passed in 0.004s
  • ✅ UIComponents.Tests.UIComponentTests+Initialization - 8/8 - Passed in 0.036s
    • Allows_Waiting_For_Initialization - Passed in 0.014s
    • Asynchronous_Initialization_Happens_Once - Passed in 0.014s
    • Bare_Component_Initializes_Synchronously - Passed in 0.001s
    • Completes_Initialization_Task - Passed in 0.001s
    • Does_Not_Initialize_If_Children_Are_Uninitialized - Passed in 0.003s
    • Initializes_When_Children_Are_Initialized - Passed in 0.002s
    • Sets_The_Initialized_Value - Passed in 0.001s
    • Synchronous_Initialization_Happens_Once - Passed in 0.001s
  • ✅ UIComponents.Tests.Addressables.AddressableAssetResolverTests - 3/3 - Passed in 0.435s
    • Caches_Asset_Existence_Checks - Passed in 0.172s
    • Should_Be_Able_To_Load_Existing_Asset - Passed in 0.237s
    • Should_Be_Able_To_Tell_If_Asset_Exists - Passed in 0.026s
  • ✅ UIComponents.Tests.Roslyn.ProvideErrorTests - 2/2 - Passed in 0.006s
    • Error_Is_Printed_With_DebugLog - Passed in 0.003s
    • Error_Is_Printed_With_Logger - Passed in 0.002s
  • ✅ UIComponents.Tests.Roslyn.UxmlNameTests - 1/1 - Passed in 0.009s
    • Generates_Uxml_Factory_For_Name - Passed in 0.009s
  • ✅ UIComponents.Tests.Roslyn.UxmlTraitTests - 3/3 - Passed in 0.033s
    • Generates_Traits_For_Nested_Class - Passed in 0.003s
    • Generates_Traits_For_Non_UIComponent_Class - Passed in 0.012s
    • Generates_Traits_For_UIComponent_Class - Passed in 0.018s