Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle returning to ice gathering stage #68

Open
johanhelsing opened this issue Jan 12, 2023 · 5 comments
Open

Handle returning to ice gathering stage #68

johanhelsing opened this issue Jan 12, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@johanhelsing
Copy link
Owner

Currently we stop anything related to ice once the data channel has opened, however It's possible to return to the ice gathering state, and we should probably handle that.

Ref this comment:

// TODO: we should support getting new ICE candidates even after connecting,

https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/iceGatheringState

@simbleau
Copy link
Collaborator

Is this only for WASM?

@johanhelsing
Copy link
Owner Author

I don't know/remember. Not really sure exactly what kinds of things will trigger additional gathering either.

Perhaps if you enable or disable wireless?

I wrote this down mostly because i saw it in the mdn docs and didn't want to forget about it.

@johanhelsing johanhelsing added the enhancement New feature or request label Feb 21, 2023
@johanhelsing
Copy link
Owner Author

@simbleau
Copy link
Collaborator

simbleau commented Feb 24, 2023

This sounds low priority since it is a network renegotiation under rare circumstances to increase performance, not to solve a severe problem in connectivity.

Good find.

@johanhelsing
Copy link
Owner Author

Yes, let's ignore it for now, we have bigger fishes to fry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants