Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code duplicities in JavaScript in User Interfaces #27

Open
jkuchar opened this issue Jul 9, 2014 · 3 comments
Open

Remove code duplicities in JavaScript in User Interfaces #27

jkuchar opened this issue Jul 9, 2014 · 3 comments
Labels
enhancement
Milestone
v2.0.0

Comments

@jkuchar
Copy link
Owner

jkuchar commented Jul 9, 2014

Code duplicity is always wrong. And here it looks like huge whole class is copied into each interface.
@jkuchar jkuchar added this to the v2.0.0 milestone Jul 9, 2014
@Ciki
Copy link
Collaborator

Ciki commented Jul 9, 2014

where exactly?

@jkuchar
Copy link
Owner Author

jkuchar commented Jul 10, 2014

Look at this commit, there is the same code 3 times. :-)

d00682d

Lines:
d00682d#diff-b00949811c8f0921e4f29077c76e2912R1
d00682d#diff-64b783938728936db12d11275364ee4aR8
d00682d#diff-3799f06dcf41d845e9d975c3e2bdfb30R9

@Ciki
Copy link
Collaborator

Ciki commented Jul 10, 2014

aah, sure. the part commented as 'COMMON CODEBASE FOR ALL INTERFACES' .. It should be refactored for sure... :)

@jkuchar jkuchar changed the title Remove code duplicities in JavaScript in User Interfaces (look into Ciki's commits) Remove code duplicities in JavaScript in User Interfaces Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@jkuchar @Ciki