Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small nuisance with /run/vdev #49

Open
onimatrix81 opened this issue Aug 22, 2015 · 4 comments
Open

Small nuisance with /run/vdev #49

onimatrix81 opened this issue Aug 22, 2015 · 4 comments

Comments

@onimatrix81
Copy link

In /etc/vdev/vdevd.conf I left pidfile to be written to /run/vdev/vdev.pid. As good of a file as any afaik. Whose responsibility however is it to create the directory, because vdevd just errors out if it doesn't exist?

@jaromil
Copy link

jaromil commented Aug 22, 2015

this is a good behavior across *nix daemons, creating non existing directories may introduce security rirks. It is the responsibility of the caller to create them.

@fbt
Copy link
Contributor

fbt commented Aug 22, 2015

Agreed, I have no problems with initscripts creating directories.

@jcnelson
Copy link
Owner

@onimatrix81 The init script should make /run/vdev. Looks like the included init script does not do this; I just pushed a patch to make it do so.

@onimatrix81
Copy link
Author

Yeah jcnelson. Heh, I had no idea about that. It was "an issue" when I kept starting vdevd manually. My OpenRC init script does this too as Jaromil abd fbt cleared it out that this was desired behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants